GeezerVison is showing github.com — deps: remove problematic comment from v8-internal · nodejs/node@0660b94
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: common.gypi +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
38 | 38 |
|
39 | 39 | # Reset this number to 0 on major V8 upgrades. |
40 | 40 | # Increment by one for each non-official patch applied to deps/v8. |
41 | | - 'v8_embedder_string': '-node.2', |
| 41 | + 'v8_embedder_string': '-node.3', |
42 | 42 |
|
43 | 43 | ##### V8 defaults for Node.js ##### |
44 | 44 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: deps/v8/include/v8-internal.h -13Lines changed: 0 additions & 13 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -432,19 +432,6 @@ constexpr size_t kMaxCppHeapPointers = 0; |
432 | 432 | // which all subtypes of a given supertype use contiguous tags. This struct can |
433 | 433 | // then be used to represent such a type range. |
434 | 434 | // |
435 | | -// As an example, consider the following type hierarchy: |
436 | | -// |
437 | | -// A F |
438 | | -// / \ |
439 | | -// B E |
440 | | -// / \ |
441 | | -// C D |
442 | | -// |
443 | | -// A potential type id assignment for range-based type checks is |
444 | | -// {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A |
445 | | -// would check for the range [A, E], while the check for B would check range |
446 | | -// [B, D], and for F it would simply check [F, F]. |
447 | | -// |
448 | 435 | // In addition, there is an option for performance tweaks: if the size of the |
449 | 436 | // type range corresponding to a supertype is a power of two and starts at a |
450 | 437 | // power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize |
|