GeezerVison is showing github.com — Revert "build: avoid compiling with VS v17.12" · nodejs/node@08e5309
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: vcbuild.bat +1-10Lines changed: 1 addition & 10 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -292,19 +292,10 @@ goto exit |
292 | 292 | @rem Visual Studio v17.10 has a bug that causes the build to fail. |
293 | 293 | @rem Check if the version is v17.10 and exit if it is. |
294 | 294 | echo %VSCMD_VER% | findstr /b /c:"17.10" >nul |
295 | | -if %errorlevel% neq 1 ( |
| 295 | +if %errorlevel% neq 1 ( |
296 | 296 | echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version. |
297 | 297 | goto exit |
298 | 298 | ) |
299 | | -@rem Same applies to v17.12 for MSVC. |
300 | | -echo %VSCMD_VER% | findstr /b /c:"17.12" >nul |
301 | | -if %errorlevel% neq 1 ( |
302 | | - @rem Clang 18.1.8 Provided with VS 17.12 works fine. |
303 | | - if not defined clang_cl ( |
304 | | - echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version. |
305 | | - goto exit |
306 | | - ) |
307 | | -) |
308 | 299 |
|
309 | 300 | @rem check if the clang-cl build is requested |
310 | 301 | if not defined clang_cl goto clang-skip |
|