GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix build with Python 3.12 · nodejs/node@0a5e9c1

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • configure.py
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+5-6Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
import io
1515
from pathlib import Path
1616

17-
from distutils.version import StrictVersion
18-
1917
# If not run from node/, cd to node/.
2018
os.chdir(Path(__file__).parent)
2119

@@ -30,6 +28,7 @@
3028

3129
sys.path.insert(0, str(tools_path / 'gyp' / 'pylib'))
3230
from gyp.common import GetFlavor
31+
from packaging.version import Version
3332

3433
# imports in tools/configure.d
3534
sys.path.insert(0, str(tools_path / 'configure.d'))
@@ -1565,10 +1564,10 @@ def without_ssl_error(option):
15651564
# supported asm compiler for AVX2. See https://github.com/openssl/openssl/
15661565
# blob/OpenSSL_1_1_0-stable/crypto/modes/asm/aesni-gcm-x86_64.pl#L52-L69
15671566
openssl110_asm_supported = \
1568-
('gas_version' in variables and StrictVersion(variables['gas_version']) >= StrictVersion('2.23')) or \
1569-
('xcode_version' in variables and StrictVersion(variables['xcode_version']) >= StrictVersion('5.0')) or \
1570-
('llvm_version' in variables and StrictVersion(variables['llvm_version']) >= StrictVersion('3.3')) or \
1571-
('nasm_version' in variables and StrictVersion(variables['nasm_version']) >= StrictVersion('2.10'))
1567+
('gas_version' in variables and Version(variables['gas_version']) >= Version('2.23')) or \
1568+
('xcode_version' in variables and Version(variables['xcode_version']) >= Version('5.0')) or \
1569+
('llvm_version' in variables and Version(variables['llvm_version']) >= Version('3.3')) or \
1570+
('nasm_version' in variables and Version(variables['nasm_version']) >= Version('2.10'))
15721571

15731572
if is_x86 and not openssl110_asm_supported:
15741573
error('''Did not find a new enough assembler, install one or build with

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.