GeezerVison is showing github.com — tools: improve macOS notarization process output readability · nodejs/node@0aaab45
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: tools/osx-notarize.sh +10-13Lines changed: 10 additions & 13 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
37 | 37 | # Submit the package for notarization |
38 | 38 | # TODO(@ulisesGascon): refactor to use --keychain-profile |
39 | 39 | # when https://github.com/nodejs/build/issues/3385#issuecomment-1729281269 is ready |
40 | | -notarization_output=$( |
41 | | - xcrun notarytool submit \ |
42 | | - --apple-id "$NOTARIZATION_ID" \ |
43 | | - --password "$NOTARIZATION_PASSWORD" \ |
44 | | - --team-id "$NOTARIZATION_TEAM_ID" \ |
45 | | - --wait \ |
46 | | - "node-$pkgid.pkg" 2>&1 |
47 | | -) |
| 40 | +echo "Submitting node-$pkgid.pkg for notarization..." |
| 41 | + |
| 42 | +xcrun notarytool submit \ |
| 43 | + --apple-id "$NOTARIZATION_ID" \ |
| 44 | + --password "$NOTARIZATION_PASSWORD" \ |
| 45 | + --team-id "$NOTARIZATION_TEAM_ID" \ |
| 46 | + --wait \ |
| 47 | + "node-$pkgid.pkg" |
48 | 48 |
|
49 | 49 | if [ $? -eq 0 ]; then |
50 | | - # Extract the operation ID from the output |
51 | | - operation_id=$(echo "$notarization_output" | awk '/RequestUUID/ {print $NF}') |
52 | | - echo "Notarization submitted. Operation ID: $operation_id" |
| 50 | + echo "Notarization node-$pkgid.pkg submitted successfully." |
53 | 51 | exit 0 |
54 | 52 | else |
55 | | - echo "Notarization failed. Error: $notarization_output" |
| 53 | + echo "Notarization node-$pkgid.pkg failed." |
56 | 54 | exit 1 |
57 | 55 | fi |
58 | | - |