GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src,test: track `URL.canParse` fast API calls · nodejs/node@0b16af1

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_url.cc
test/parallel
- test-url-canParse-whatwg.js
- test-whatwg-url-canparse.js
typings/internalBinding
- url.d.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_url.cc‎`

Copy file name to clipboardExpand all lines: src/node_url.cc

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`#include "node_url.h"`
`2`	`2`	`#include "ada.h"`
`3`	`3`	`#include "base_object-inl.h"`
	`4`	`+#include "node_debug.h"`
`4`	`5`	`#include "node_errors.h"`
`5`	`6`	`#include "node_external_reference.h"`
`6`	`7`	`#include "node_i18n.h"`
`@@ -173,12 +174,14 @@ void BindingData::CanParse(const FunctionCallbackInfo<Value>& args) {`
`173`	`174`
`174`	`175`	`bool BindingData::FastCanParse(Local<Value> receiver,`
`175`	`176`	`const FastOneByteString& input) {`
	`177`	`+ TRACK_V8_FAST_API_CALL("url.canParse");`
`176`	`178`	`return ada::can_parse(std::string_view(input.data, input.length));`
`177`	`179`	`}`
`178`	`180`
`179`	`181`	`bool BindingData::FastCanParseWithBase(Local<Value> receiver,`
`180`	`182`	`const FastOneByteString& input,`
`181`	`183`	`const FastOneByteString& base) {`
	`184`	`+ TRACK_V8_FAST_API_CALL("url.canParse.withBase");`
`182`	`185`	`auto base_view = std::string_view(base.data, base.length);`
`183`	`186`	`return ada::can_parse(std::string_view(input.data, input.length), &base_view);`
`184`	`187`	`}`

Collapse file

`‎test/parallel/test-url-canParse-whatwg.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-url-canParse-whatwg.js

-19Lines changed: 0 additions & 19 deletions

This file was deleted.

Collapse file

`‎test/parallel/test-whatwg-url-canparse.js‎`

Copy file name to clipboard

+27-18Lines changed: 27 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,29 +1,38 @@`
`1`		`-// Flags: --expose-internals`
	`1`	`+// Flags: --expose-internals --no-warnings --allow-natives-syntax`
`2`	`2`	`'use strict';`
`3`	`3`
`4`		`-require('../common');`
	`4`	`+const common = require('../common');`
`5`	`5`
`6`	`6`	`const { URL } = require('url');`
`7`	`7`	`const assert = require('assert');`
`8`	`8`
`9`		`-let internalBinding;`
`10`		`-try {`
`11`		`- internalBinding = require('internal/test/binding').internalBinding;`
`12`		`-} catch (e) {`
`13`		- console.log('using `test/parallel/test-whatwg-url-canparse` requires `--expose-internals`');
`14`		`- throw e;`
`15`		`-}`
	`9`	`+const { internalBinding } = require('internal/test/binding');`
`16`	`10`
`17`		`-const { canParse } = internalBinding('url');`
	`11`	`+// One argument is required`
	`12`	`+assert.throws(() => {`
	`13`	`+ URL.canParse();`
	`14`	`+}, {`
	`15`	`+ code: 'ERR_MISSING_ARGS',`
	`16`	`+ name: 'TypeError',`
	`17`	`+});`
`18`	`18`
`19`	`19`	`// It should not throw when called without a base string`
`20`	`20`	`assert.strictEqual(URL.canParse('https://example.org'), true);`
`21`		`-assert.strictEqual(canParse('https://example.org'), true);`
`22`		`-`
`23`		`-// This for-loop is used to test V8 Fast API optimizations`
`24`		`-for (let i = 0; i < 100000; i++) {`
`25`		`- // This example is used because only parsing the first parameter`
`26`		`- // results in an invalid URL. They have to be used together to`
`27`		`- // produce truthy value.`
`28`		`- assert.strictEqual(URL.canParse('/', 'http://n'), true);`
	`21`	`+`
	`22`	`+if (common.isDebug) {`
	`23`	`+ const { getV8FastApiCallCount } = internalBinding('debug');`
	`24`	`+`
	`25`	`+ function testFastPaths() {`
	`26`	+ // `canParse` binding has two overloads.
	`27`	`+ assert.strictEqual(URL.canParse('https://www.example.com/path/?query=param#hash'), true);`
	`28`	`+ assert.strictEqual(URL.canParse('/', 'http://n'), true);`
	`29`	`+ }`
	`30`	`+`
	`31`	`+ eval('%PrepareFunctionForOptimization(URL.canParse)');`
	`32`	`+ testFastPaths();`
	`33`	`+ eval('%OptimizeFunctionOnNextCall(URL.canParse)');`
	`34`	`+ testFastPaths();`
	`35`	`+`
	`36`	`+ assert.strictEqual(getV8FastApiCallCount('url.canParse'), 1);`
	`37`	`+ assert.strictEqual(getV8FastApiCallCount('url.canParse.withBase'), 1);`
`29`	`38`	`}`

Collapse file

`‎typings/internalBinding/url.d.ts‎`

Copy file name to clipboardExpand all lines: typings/internalBinding/url.d.ts

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ export interface URLBinding {`
`6`	`6`	`domainToASCII(input: string): string;`
`7`	`7`	`domainToUnicode(input: string): string;`
`8`	`8`	`canParse(input: string): boolean;`
	`9`	`+ canParse(input: string, base: string): boolean;`
`9`	`10`	`format(input: string, fragment?: boolean, unicode?: boolean, search?: boolean, auth?: boolean): string;`
`10`	`11`	`parse(input: string, base?: string): string \| false;`
`11`	`12`	`update(input: string, actionType: typeof urlUpdateActions, value: string): string \| false;`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.