GeezerVison is showing github.com — Revert "build: remove precompiled header and debug information for ho… · nodejs/node@0f3cf7e
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: common.gypi +1-5Lines changed: 1 addition & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 283 | 283 | '-std:c++17' | 284 | 284 | ], | 285 | 285 | 'BufferSecurityCheck': 'true', | 286 | | - 'target_conditions': [ | 287 | | - ['_toolset=="target"', { | 288 | | - 'DebugInformationFormat': 1 # /Z7 embed info in .obj files | 289 | | - }], | 290 | | - ], | | 286 | + 'DebugInformationFormat': 1, # /Z7 embed info in .obj files | 291 | 287 | 'ExceptionHandling': 0, # /EHsc | 292 | 288 | 'MultiProcessorCompilation': 'true', | 293 | 289 | 'StringPooling': 'true', # pool string literals | |
Collapse file Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp +5-7Lines changed: 5 additions & 7 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 325 | 325 | '<(V8_ROOT)/src/builtins/builtins-intl-gen.cc', | 326 | 326 | ], | 327 | 327 | }], | 328 | | - ['OS=="win" and _toolset=="target"', { | | 328 | + ['OS=="win"', { | 329 | 329 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 330 | 330 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 331 | 331 | 'sources': [ | | 683 | 683 | ], | 684 | 684 | 'sources': ['<@(v8_compiler_sources)'], | 685 | 685 | 'conditions': [ | 686 | | - ['OS=="win" and _toolset=="target"', { | | 686 | + ['OS=="win"', { | 687 | 687 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 688 | 688 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 689 | 689 | 'sources': [ | | 708 | 708 | ], | 709 | 709 | 'sources': ['<@(v8_compiler_sources)'], | 710 | 710 | 'conditions': [ | 711 | | - ['OS=="win" and _toolset=="target"', { | | 711 | + ['OS=="win"', { | 712 | 712 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 713 | 713 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 714 | 714 | 'sources': [ | | 908 | 908 | '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")', | 909 | 909 | ], | 910 | 910 | }], | 911 | | - ['OS=="win" and _toolset=="target"', { | | 911 | + ['OS=="win"', { | 912 | 912 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 913 | 913 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 914 | 914 | 'sources': [ | 915 | 915 | '<(_msvs_precompiled_header)', | 916 | 916 | '<(_msvs_precompiled_source)', | 917 | | - ] | 918 | | - }], | 919 | | - ['OS=="win"', { | | 917 | + ], | 920 | 918 | # This will prevent V8's .cc files conflicting with the inspector's | 921 | 919 | # .cpp files in the same shard. | 922 | 920 | 'msvs_settings': { | |
|