GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — util: fix formatting of functions returned from getters · nodejs/node@10e2603

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/util
- inspect.js
test/parallel
- test-util-inspect.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/util/inspect.js‎`

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2304,7 +2304,7 @@ function formatProperty(ctx, value, recurseTimes, key, type, desc,`
`2304`	`2304`	`const tmp = FunctionPrototypeCall(desc.get, original);`
`2305`	`2305`	`if (tmp === null) {`
`2306`	`2306`	str = `${s(`[${label}:`, sp)} ${s('null', 'null')}${s(']', sp)}`;
`2307`		`- } else if (typeof tmp === 'object') {`
	`2307`	`+ } else if (typeof tmp === 'object' \|\| typeof tmp === 'function') {`
`2308`	`2308`	str = `${s(`[${label}]`, sp)} ${formatValue(ctx, tmp, recurseTimes)}`;
`2309`	`2309`	`} else {`
`2310`	`2310`	`const primitive = formatPrimitive(s, tmp, ctx);`

Collapse file

`‎test/parallel/test-util-inspect.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-util-inspect.js

+14-8Lines changed: 14 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -2596,6 +2596,15 @@ assert.strictEqual(`
`2596`	`2596`	`"'foobar', { x: 1 } },\n inc: [Getter: NaN]\n}");`
`2597`	`2597`	`}`
`2598`	`2598`
	`2599`	`+// Getter returning a function.`
	`2600`	`+// https://github.com/nodejs/node/issues/64838`
	`2601`	`+{`
	`2602`	`+ const obj = { get foo() { return function bar() {}; } };`
	`2603`	`+ assert.strictEqual(`
	`2604`	`+ inspect(obj, { getters: true }),`
	`2605`	`+ '{ foo: [Getter] [Function: bar] }');`
	`2606`	`+}`
	`2607`	`+`
`2599`	`2608`	`// Property getter throwing an error.`
`2600`	`2609`	`{`
`2601`	`2610`	`const error = new Error('Oops');`
`@@ -3524,16 +3533,14 @@ assert.strictEqual(`
`3524`	`3533`	`'\x1B[2mdef: \x1B[33m5\x1B[39m\x1B[22m }'`
`3525`	`3534`	`);`
`3526`	`3535`
`3527`		`- assert.match(`
	`3536`	`+ assert.strictEqual(`
`3528`	`3537`	`inspect(Object.getPrototypeOf(bar), { showHidden: true, getters: true }),`
`3529`		`- new RegExp('^' + RegExp.escape(`
`3530`		`- '<ref *1> Foo [Map] {\n' +`
`3531`		`- ' [constructor]: [class Bar extends Foo] {\n' +`
	`3538`	`+ '<ref *2> Foo [Map] {\n' +`
	`3539`	`+ ' [constructor]: <ref *1> [class Bar extends Foo] {\n' +`
`3532`	`3540`	`' [length]: 0,\n' +`
`3533`	`3541`	`" [name]: 'Bar',\n" +`
`3534`		`- ' [prototype]: [Circular *1],\n' +`
`3535`		`- ' [Symbol(Symbol.species)]: [Getter: <Inspection threw ' +`
`3536`		`- "(TypeError: Symbol.prototype.toString requires that 'this' be a Symbol") + '.*' + RegExp.escape(')>]\n' +`
	`3542`	`+ ' [prototype]: [Circular *2],\n' +`
	`3543`	`+ ' [Symbol(Symbol.species)]: [Getter] [Circular *1]\n' +`
`3537`	`3544`	`' },\n' +`
`3538`	`3545`	`" [xyz]: [Getter: 'YES!'],\n" +`
`3539`	`3546`	`' [Symbol(nodejs.util.inspect.custom)]: [Function: [nodejs.util.inspect.custom]] {\n' +`
`@@ -3543,7 +3550,6 @@ assert.strictEqual(`
`3543`	`3550`	`' [abc]: [Getter: true],\n' +`
`3544`	`3551`	`' [def]: [Getter/Setter: false]\n' +`
`3545`	`3552`	`'}'`
`3546`		`- ) + '$', 's')`
`3547`	`3553`	`);`
`3548`	`3554`
`3549`	`3555`	`assert.strictEqual(`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.