GeezerVison is showing github.com — src: create per isolate proxy env template · nodejs/node@11b3e47
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/env.cc +1Lines changed: 1 addition & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -504,6 +504,7 @@ void IsolateData::CreateProperties() { |
504 | 504 | binding::CreateInternalBindingTemplates(this); |
505 | 505 |
|
506 | 506 | contextify::ContextifyContext::InitializeGlobalTemplates(this); |
| 507 | + CreateEnvProxyTemplate(this); |
507 | 508 | } |
508 | 509 |
|
509 | 510 | constexpr uint16_t kDefaultCppGCEmebdderID = 0x90de; |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_env_var.cc +2-1Lines changed: 2 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -456,7 +456,8 @@ static void EnvDefiner(Local<Name> property, |
456 | 456 | } |
457 | 457 | } |
458 | 458 |
|
459 | | -void CreateEnvProxyTemplate(Isolate* isolate, IsolateData* isolate_data) { |
| 459 | +void CreateEnvProxyTemplate(IsolateData* isolate_data) { |
| 460 | + Isolate* isolate = isolate_data->isolate(); |
460 | 461 | HandleScope scope(isolate); |
461 | 462 | if (!isolate_data->env_proxy_template().IsEmpty()) return; |
462 | 463 | Local<FunctionTemplate> env_proxy_ctor_template = |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_process.h +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -15,7 +15,7 @@ class MemoryTracker; |
15 | 15 | class ExternalReferenceRegistry; |
16 | 16 | class Realm; |
17 | 17 |
|
18 | | -void CreateEnvProxyTemplate(v8::Isolate* isolate, IsolateData* isolate_data); |
| 18 | +void CreateEnvProxyTemplate(IsolateData* isolate_data); |
19 | 19 |
|
20 | 20 | // Most of the time, it's best to use `console.error` to write |
21 | 21 | // to the process.stderr stream. However, in some cases, such as |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_realm.cc +3-2Lines changed: 3 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -344,10 +344,11 @@ MaybeLocal<Value> PrincipalRealm::BootstrapRealm() { |
344 | 344 | return MaybeLocal<Value>(); |
345 | 345 | } |
346 | 346 |
|
| 347 | + // Setup process.env proxy. |
347 | 348 | Local<String> env_string = FIXED_ONE_BYTE_STRING(isolate_, "env"); |
348 | 349 | Local<Object> env_proxy; |
349 | | - CreateEnvProxyTemplate(isolate_, env_->isolate_data()); |
350 | | - if (!env_->env_proxy_template()->NewInstance(context()).ToLocal(&env_proxy) || |
| 350 | + if (!isolate_data()->env_proxy_template()->NewInstance(context()).ToLocal( |
| 351 | + &env_proxy) || |
351 | 352 | process_object()->Set(context(), env_string, env_proxy).IsNothing()) { |
352 | 353 | return MaybeLocal<Value>(); |
353 | 354 | } |
|