GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: forbid running watch mode in REPL · nodejs/node@169b33a

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node.cc‎`

Copy file name to clipboardExpand all lines: src/node.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ MaybeLocal<Value> StartExecution(Environment* env, StartExecutionCallback cb) {`
`347`	`347`	`return StartExecution(env, "internal/main/test_runner");`
`348`	`348`	`}`
`349`	`349`
`350`		`- if (env->options()->watch_mode && !first_argv.empty()) {`
	`350`	`+ if (env->options()->watch_mode) {`
`351`	`351`	`return StartExecution(env, "internal/main/watch_mode");`
`352`	`352`	`}`
`353`	`353`

Collapse file

`‎src/node_options-inl.h‎`

Copy file name to clipboardExpand all lines: src/node_options-inl.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -466,7 +466,7 @@ void OptionsParser<Options>::Parse(`
`466`	`466`	`UNREACHABLE();`
`467`	`467`	`}`
`468`	`468`	`}`
`469`		`- options->CheckOptions(errors);`
	`469`	`+ options->CheckOptions(errors, orig_args);`
`470`	`470`	`}`
`471`	`471`
`472`	`472`	`} // namespace options_parser`

Collapse file

`‎src/node_options.cc‎`

Copy file name to clipboardExpand all lines: src/node_options.cc

+15-13Lines changed: 15 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ Mutex cli_options_mutex;`
`34`	`34`	`std::shared_ptr<PerProcessOptions> cli_options{new PerProcessOptions()};`
`35`	`35`	`} // namespace per_process`
`36`	`36`
`37`		`-void DebugOptions::CheckOptions(std::vector<std::string>* errors) {`
	`37`	`+void DebugOptions::CheckOptions(std::vector<std::string>* errors,`
	`38`	`+ std::vector<std::string>* argv) {`
`38`	`39`	`#if !NODE_USE_V8_PLATFORM && !HAVE_INSPECTOR`
`39`	`40`	`if (inspector_enabled) {`
`40`	`41`	`errors->push_back("Inspector is not available when Node is compiled "`
`@@ -64,7 +65,8 @@ void DebugOptions::CheckOptions(std::vector<std::string>* errors) {`
`64`	`65`	`}`
`65`	`66`	`}`
`66`	`67`
`67`		`-void PerProcessOptions::CheckOptions(std::vector<std::string>* errors) {`
	`68`	`+void PerProcessOptions::CheckOptions(std::vector<std::string>* errors,`
	`69`	`+ std::vector<std::string>* argv) {`
`68`	`70`	`#if HAVE_OPENSSL`
`69`	`71`	`if (use_openssl_ca && use_bundled_ca) {`
`70`	`72`	`errors->push_back("either --use-openssl-ca or --use-bundled-ca can be "`
`@@ -91,14 +93,16 @@ void PerProcessOptions::CheckOptions(std::vector<std::string>* errors) {`
`91`	`93`	`use_largepages != "silent") {`
`92`	`94`	`errors->push_back("invalid value for --use-largepages");`
`93`	`95`	`}`
`94`		`- per_isolate->CheckOptions(errors);`
	`96`	`+ per_isolate->CheckOptions(errors, argv);`
`95`	`97`	`}`
`96`	`98`
`97`		`-void PerIsolateOptions::CheckOptions(std::vector<std::string>* errors) {`
`98`		`- per_env->CheckOptions(errors);`
	`99`	`+void PerIsolateOptions::CheckOptions(std::vector<std::string>* errors,`
	`100`	`+ std::vector<std::string>* argv) {`
	`101`	`+ per_env->CheckOptions(errors, argv);`
`99`	`102`	`}`
`100`	`103`
`101`		`-void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors) {`
	`104`	`+void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors,`
	`105`	`+ std::vector<std::string>* argv) {`
`102`	`106`	`if (has_policy_integrity_string && experimental_policy.empty()) {`
`103`	`107`	`errors->push_back("--policy-integrity requires "`
`104`	`108`	`"--experimental-policy be enabled");`
`@@ -169,15 +173,13 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors) {`
`169`	`173`	`if (watch_mode) {`
`170`	`174`	`if (syntax_check_only) {`
`171`	`175`	`errors->push_back("either --watch or --check can be used, not both");`
`172`		`- }`
`173`		`-`
`174`		`- if (has_eval_string) {`
	`176`	`+ } else if (has_eval_string) {`
`175`	`177`	`errors->push_back("either --watch or --eval can be used, not both");`
`176`		`- }`
`177`		`-`
`178`		`- if (force_repl) {`
	`178`	`+ } else if (force_repl) {`
`179`	`179`	`errors->push_back("either --watch or --interactive "`
`180`	`180`	`"can be used, not both");`
	`181`	`+ } else if (argv->size() < 1 \|\| (*argv)[1].empty()) {`
	`182`	`+ errors->push_back("--watch requires specifying a file");`
`181`	`183`	`}`
`182`	`184`
`183`	`185`	`#ifndef ALLOW_ATTACHING_DEBUGGER_IN_WATCH_MODE`
`@@ -222,7 +224,7 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors) {`
`222`	`224`	`heap_prof_dir = diagnostic_dir;`
`223`	`225`	`}`
`224`	`226`
`225`		`- debug_options_.CheckOptions(errors);`
	`227`	`+ debug_options_.CheckOptions(errors, argv);`
`226`	`228`	`#endif // HAVE_INSPECTOR`
`227`	`229`	`}`
`228`	`230`

Collapse file

`‎src/node_options.h‎`

Copy file name to clipboardExpand all lines: src/node_options.h

+10-5Lines changed: 10 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ class HostPort {`
`50`	`50`
`51`	`51`	`class Options {`
`52`	`52`	`public:`
`53`		`- virtual void CheckOptions(std::vector<std::string>* errors) {}`
	`53`	`+ virtual void CheckOptions(std::vector<std::string>* errors,`
	`54`	`+ std::vector<std::string>* argv) {}`
`54`	`55`	`virtual ~Options() = default;`
`55`	`56`	`};`
`56`	`57`
`@@ -99,7 +100,8 @@ class DebugOptions : public Options {`
`99`	`100`	`return break_first_line \|\| break_node_first_line;`
`100`	`101`	`}`
`101`	`102`
`102`		`- void CheckOptions(std::vector<std::string>* errors) override;`
	`103`	`+ void CheckOptions(std::vector<std::string>* errors,`
	`104`	`+ std::vector<std::string>* argv) override;`
`103`	`105`	`};`
`104`	`106`
`105`	`107`	`class EnvironmentOptions : public Options {`
`@@ -202,7 +204,8 @@ class EnvironmentOptions : public Options {`
`202`	`204`	`inline DebugOptions* get_debug_options() { return &debug_options_; }`
`203`	`205`	`inline const DebugOptions& debug_options() const { return debug_options_; }`
`204`	`206`
`205`		`- void CheckOptions(std::vector<std::string>* errors) override;`
	`207`	`+ void CheckOptions(std::vector<std::string>* errors,`
	`208`	`+ std::vector<std::string>* argv) override;`
`206`	`209`
`207`	`210`	`private:`
`208`	`211`	`DebugOptions debug_options_;`
`@@ -217,7 +220,8 @@ class PerIsolateOptions : public Options {`
`217`	`220`	`bool experimental_shadow_realm = false;`
`218`	`221`	`std::string report_signal = "SIGUSR2";`
`219`	`222`	`inline EnvironmentOptions* get_per_env_options();`
`220`		`- void CheckOptions(std::vector<std::string>* errors) override;`
	`223`	`+ void CheckOptions(std::vector<std::string>* errors,`
	`224`	`+ std::vector<std::string>* argv) override;`
`221`	`225`	`};`
`222`	`226`
`223`	`227`	`class PerProcessOptions : public Options {`
`@@ -290,7 +294,8 @@ class PerProcessOptions : public Options {`
`290`	`294`	`std::vector<std::string> cmdline;`
`291`	`295`
`292`	`296`	`inline PerIsolateOptions* get_per_isolate_options();`
`293`		`- void CheckOptions(std::vector<std::string>* errors) override;`
	`297`	`+ void CheckOptions(std::vector<std::string>* errors,`
	`298`	`+ std::vector<std::string>* argv) override;`
`294`	`299`	`};`
`295`	`300`
`296`	`301`	`// The actual options parser, as opposed to the structs containing them:`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.