GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: increase debugging information in subprocess test · nodejs/node@193a020

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test/parallel
    • test-child-process-pipe-dataflow.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-child-process-pipe-dataflow.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-pipe-dataflow.js
+11-1Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,14 @@ const MB = KB * KB;
3737
cat.stdout._handle.readStart = common.mustNotCall();
3838
grep.stdout._handle.readStart = common.mustNotCall();
3939

40+
// Keep an array of error codes and assert on them during process exit. This
41+
// is because stdio can still be open when a child process exits, and we don't
42+
// want to lose information about what caused the error.
43+
const errors = [];
44+
process.on('exit', () => {
45+
assert.deepStrictEqual(errors, []);
46+
});
47+
4048
[cat, grep, wc].forEach((child, index) => {
4149
const errorHandler = (thing, type) => {
4250
// Don't want to assert here, as we might miss error code info.
@@ -46,7 +54,9 @@ const MB = KB * KB;
4654
child.stderr.on('data', (d) => { errorHandler(d, 'data'); });
4755
child.on('error', (err) => { errorHandler(err, 'error'); });
4856
child.on('exit', common.mustCall((code) => {
49-
assert.strictEqual(code, 0, `child ${index} exited with code ${code}`);
57+
if (code !== 0) {
58+
errors.push(`child ${index} exited with code ${code}`);
59+
}
5060
}));
5161
});
5262

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.