GeezerVison is showing github.com — Revert "build: remove precompiled header and debug information for ho… · nodejs/node@1de1f67
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: common.gypi +1-5Lines changed: 1 addition & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 283 | 283 | '-std:c++17' | 284 | 284 | ], | 285 | 285 | 'BufferSecurityCheck': 'true', | 286 | | - 'target_conditions': [ | 287 | | - ['_toolset=="target"', { | 288 | | - 'DebugInformationFormat': 1 # /Z7 embed info in .obj files | 289 | | - }], | 290 | | - ], | | 286 | + 'DebugInformationFormat': 1, # /Z7 embed info in .obj files | 291 | 287 | 'ExceptionHandling': 0, # /EHsc | 292 | 288 | 'MultiProcessorCompilation': 'true', | 293 | 289 | 'StringPooling': 'true', # pool string literals | |
Collapse file Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp +5-7Lines changed: 5 additions & 7 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 327 | 327 | '<(V8_ROOT)/src/builtins/builtins-intl-gen.cc', | 328 | 328 | ], | 329 | 329 | }], | 330 | | - ['OS=="win" and _toolset=="target"', { | | 330 | + ['OS=="win"', { | 331 | 331 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 332 | 332 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 333 | 333 | 'sources': [ | | 685 | 685 | ], | 686 | 686 | 'sources': ['<@(v8_compiler_sources)'], | 687 | 687 | 'conditions': [ | 688 | | - ['OS=="win" and _toolset=="target"', { | | 688 | + ['OS=="win"', { | 689 | 689 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 690 | 690 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 691 | 691 | 'sources': [ | | 710 | 710 | ], | 711 | 711 | 'sources': ['<@(v8_compiler_sources)'], | 712 | 712 | 'conditions': [ | 713 | | - ['OS=="win" and _toolset=="target"', { | | 713 | + ['OS=="win"', { | 714 | 714 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 715 | 715 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 716 | 716 | 'sources': [ | | 912 | 912 | '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")', | 913 | 913 | ], | 914 | 914 | }], | 915 | | - ['OS=="win" and _toolset=="target"', { | | 915 | + ['OS=="win"', { | 916 | 916 | 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', | 917 | 917 | 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', | 918 | 918 | 'sources': [ | 919 | 919 | '<(_msvs_precompiled_header)', | 920 | 920 | '<(_msvs_precompiled_source)', | 921 | | - ] | 922 | | - }], | 923 | | - ['OS=="win"', { | | 921 | + ], | 924 | 922 | # This will prevent V8's .cc files conflicting with the inspector's | 925 | 923 | # .cpp files in the same shard. | 926 | 924 | 'msvs_settings': { | |
|