GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: use automatic memory mgmt in SecretKeyGen · nodejs/node@1f54fc2

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src/crypto
- crypto_keygen.cc
- crypto_keygen.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/crypto/crypto_keygen.cc‎`

Copy file name to clipboardExpand all lines: src/crypto/crypto_keygen.cc

+8-10Lines changed: 8 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,7 @@ EVPKeyCtxPointer NidKeyPairGenTraits::Setup(NidKeyPairGenConfig* params) {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`void SecretKeyGenConfig::MemoryInfo(MemoryTracker* tracker) const {`
`57`		`- if (out != nullptr)`
`58`		`- tracker->TrackFieldWithSize("out", length);`
	`57`	`+ if (out) tracker->TrackFieldWithSize("out", length);`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`Maybe<bool> SecretKeyGenTraits::AdditionalConfig(`
`@@ -80,18 +79,17 @@ KeyGenJobStatus SecretKeyGenTraits::DoKeyGen(`
`80`	`79`	`Environment* env,`
`81`	`80`	`SecretKeyGenConfig* params) {`
`82`	`81`	`CHECK_LE(params->length, INT_MAX);`
`83`		`- params->out = MallocOpenSSL<char>(params->length);`
`84`		`- EntropySource(reinterpret_cast<unsigned char*>(params->out), params->length);`
	`82`	`+ ByteSource::Builder bytes(params->length);`
	`83`	`+ EntropySource(bytes.data<unsigned char>(), params->length);`
	`84`	`+ params->out = std::move(bytes).release();`
`85`	`85`	`return KeyGenJobStatus::OK;`
`86`	`86`	`}`
`87`	`87`
`88`		`-Maybe<bool> SecretKeyGenTraits::EncodeKey(`
`89`		`- Environment* env,`
`90`		`- SecretKeyGenConfig* params,`
`91`		`- Local<Value>* result) {`
`92`		`- ByteSource out = ByteSource::Allocated(params->out, params->length);`
	`88`	`+Maybe<bool> SecretKeyGenTraits::EncodeKey(Environment* env,`
	`89`	`+ SecretKeyGenConfig* params,`
	`90`	`+ Local<Value>* result) {`
`93`	`91`	`std::shared_ptr<KeyObjectData> data =`
`94`		`- KeyObjectData::CreateSecret(std::move(out));`
	`92`	`+ KeyObjectData::CreateSecret(std::move(params->out));`
`95`	`93`	`return Just(KeyObjectHandle::Create(env, data).ToLocal(result));`
`96`	`94`	`}`
`97`	`95`

Collapse file

`‎src/crypto/crypto_keygen.h‎`

Copy file name to clipboardExpand all lines: src/crypto/crypto_keygen.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ struct KeyPairGenTraits final {`
`201`	`201`
`202`	`202`	`struct SecretKeyGenConfig final : public MemoryRetainer {`
`203`	`203`	`size_t length; // In bytes.`
`204`		`- char* out = nullptr; // Placeholder for the generated key bytes.`
	`204`	`+ ByteSource out; // Placeholder for the generated key bytes.`
`205`	`205`
`206`	`206`	`void MemoryInfo(MemoryTracker* tracker) const override;`
`207`	`207`	`SET_MEMORY_INFO_NAME(SecretKeyGenConfig)`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.