GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: use new AsyncResource instead of bind · nodejs/node@213188e

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/streams
- end-of-stream.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/streams/end-of-stream.js‎`

Copy file name to clipboardExpand all lines: lib/internal/streams/end-of-stream.js

+12-3Lines changed: 12 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ const {`
`45`	`45`	`} = require('internal/streams/utils');`
`46`	`46`
`47`	`47`	`// Lazy load`
`48`		`-let AsyncLocalStorage;`
	`48`	`+let AsyncResource;`
`49`	`49`	`let addAbortListener;`
`50`	`50`
`51`	`51`	`function isRequest(stream) {`
`@@ -54,6 +54,14 @@ function isRequest(stream) {`
`54`	`54`
`55`	`55`	`const nop = () => {};`
`56`	`56`
	`57`	`+function bindAsyncResource(fn, type) {`
	`58`	`+ AsyncResource ??= require('async_hooks').AsyncResource;`
	`59`	`+ const resource = new AsyncResource(type);`
	`60`	`+ return function(...args) {`
	`61`	`+ return resource.runInAsyncScope(fn, this, ...args);`
	`62`	`+ };`
	`63`	`+}`
	`64`	`+`
`57`	`65`	`function eos(stream, options, callback) {`
`58`	`66`	`if (arguments.length === 2) {`
`59`	`67`	`callback = options;`
`@@ -66,8 +74,9 @@ function eos(stream, options, callback) {`
`66`	`74`	`validateFunction(callback, 'callback');`
`67`	`75`	`validateAbortSignal(options.signal, 'options.signal');`
`68`	`76`
`69`		`- AsyncLocalStorage ??= require('async_hooks').AsyncLocalStorage;`
`70`		`- callback = once(AsyncLocalStorage.bind(callback));`
	`77`	`+ // Avoid AsyncResource.bind() because it calls ObjectDefineProperties which`
	`78`	`+ // is a bottleneck here.`
	`79`	`+ callback = once(bindAsyncResource(callback, 'STREAM_END_OF_STREAM'));`
`71`	`80`
`72`	`81`	`if (isReadableStream(stream) \|\| isWritableStream(stream)) {`
`73`	`82`	`return eosWeb(stream, options, callback);`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.