GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc,meta: update PR approving info · nodejs/node@2245e5e

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/guides/contributing
- pull-requests.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/guides/contributing/pull-requests.md‎`

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md

+2-1Lines changed: 2 additions & 1 deletion

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,8 @@ unhelpful is likely safe to ignore.`
`347`	`347`	`### Step 10: Landing`
`348`	`348`
`349`	`349`	`In order to land, a Pull Request needs to be reviewed and [approved][] by`
`350`		`-at least one Node.js Collaborator and pass a`
	`350`	`+at least two Node.js Collaborators (one Collaborator approval is enough if the`
	`351`	`+pull request has been open for more than 7 days) and pass a`
`351`	`352`	`[CI (Continuous Integration) test run][]. After that, as long as there are no`
`352`	`353`	`objections from other contributors, the Pull Request can be merged. If you find`
`353`	`354`	`your Pull Request waiting longer than you expect, see the`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.