GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — lib: fix return type of setTimeout in net.Socket · nodejs/node@23e56ff

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal
- stream_base_commons.js
test/parallel
- test-net-socket-timeout.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/stream_base_commons.js‎`

Copy file name to clipboardExpand all lines: lib/internal/stream_base_commons.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ function onStreamRead(arrayBuffer) {`
`233`	`233`
`234`	`234`	`function setStreamTimeout(msecs, callback) {`
`235`	`235`	`if (this.destroyed)`
`236`		`- return;`
	`236`	`+ return this;`
`237`	`237`
`238`	`238`	`this.timeout = msecs;`
`239`	`239`

Collapse file

`‎test/parallel/test-net-socket-timeout.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-net-socket-timeout.js

+8-4Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,12 @@ for (let i = 0; i < invalidCallbacks.length; i++) {`
`70`	`70`	`const server = net.Server();`
`71`	`71`	`server.listen(0, common.mustCall(() => {`
`72`	`72`	`const socket = net.createConnection(server.address().port);`
`73`		`- socket.setTimeout(1, common.mustCall(() => {`
`74`		`- socket.destroy();`
`75`		`- server.close();`
`76`		`- }));`
	`73`	`+ assert.strictEqual(`
	`74`	`+ socket.setTimeout(1, common.mustCall(() => {`
	`75`	`+ socket.destroy();`
	`76`	`+ assert.strictEqual(socket.setTimeout(1, common.mustNotCall()), socket);`
	`77`	`+ server.close();`
	`78`	`+ })),`
	`79`	`+ socket`
	`80`	`+ );`
`77`	`81`	`}));`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.