GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: remove unused function arguments in async-hooks tests · nodejs/node@2777bc4

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/async-hooks

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/async-hooks/test-promise.chain-promise-before-init-hooks.js‎`

Copy file name to clipboardExpand all lines: test/async-hooks/test-promise.chain-promise-before-init-hooks.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,11 +8,11 @@ const { checkInvocations } = require('./hook-checks');`
`8`	`8`	`if (!common.isMainThread)`
`9`	`9`	`common.skip('Worker bootstrapping works differently -> different async IDs');`
`10`	`10`
`11`		`-const p = new Promise(common.mustCall(function executor(resolve, reject) {`
	`11`	`+const p = new Promise(common.mustCall(function executor(resolve) {`
`12`	`12`	`resolve(5);`
`13`	`13`	`}));`
`14`	`14`
`15`		`-p.then(function afterresolution(val) {`
	`15`	`+p.then(function afterResolution(val) {`
`16`	`16`	`assert.strictEqual(val, 5);`
`17`	`17`	`return val;`
`18`	`18`	`});`

Collapse file

`‎test/async-hooks/test-promise.js‎`

Copy file name to clipboardExpand all lines: test/async-hooks/test-promise.js

+10-12Lines changed: 10 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,24 +13,22 @@ const hooks = initHooks();`
`13`	`13`
`14`	`14`	`hooks.enable();`
`15`	`15`
`16`		`-const p = (new Promise(common.mustCall(executor)));`
`17`		`-p.then(afterresolution);`
`18`		`-`
`19`		`-function executor(resolve, reject) {`
`20`		`- const as = hooks.activitiesOfTypes('PROMISE');`
`21`		`- assert.strictEqual(as.length, 1);`
`22`		`- const a = as[0];`
`23`		`- checkInvocations(a, { init: 1 }, 'while in promise executor');`
`24`		`- resolve(5);`
`25`		`-}`
`26`		`-`
`27`		`-function afterresolution(val) {`
	`16`	`+const p = new Promise(common.mustCall(executor));`
	`17`	`+p.then(function afterResolution(val) {`
`28`	`18`	`assert.strictEqual(val, 5);`
`29`	`19`	`const as = hooks.activitiesOfTypes('PROMISE');`
`30`	`20`	`assert.strictEqual(as.length, 2);`
`31`	`21`	`checkInvocations(as[0], { init: 1 }, 'after resolution parent promise');`
`32`	`22`	`checkInvocations(as[1], { init: 1, before: 1 },`
`33`	`23`	`'after resolution child promise');`
	`24`	`+});`
	`25`	`+`
	`26`	`+function executor(resolve) {`
	`27`	`+ const as = hooks.activitiesOfTypes('PROMISE');`
	`28`	`+ assert.strictEqual(as.length, 1);`
	`29`	`+ const a = as[0];`
	`30`	`+ checkInvocations(a, { init: 1 }, 'while in promise executor');`
	`31`	`+ resolve(5);`
`34`	`32`	`}`
`35`	`33`
`36`	`34`	`process.on('exit', onexit);`

Collapse file

`‎test/async-hooks/test-promise.promise-before-init-hooks.js‎`

Copy file name to clipboardExpand all lines: test/async-hooks/test-promise.promise-before-init-hooks.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,15 +5,15 @@ const assert = require('assert');`
`5`	`5`	`const initHooks = require('./init-hooks');`
`6`	`6`	`const { checkInvocations } = require('./hook-checks');`
`7`	`7`
`8`		`-const p = new Promise(common.mustCall(function executor(resolve, reject) {`
	`8`	`+const p = new Promise(common.mustCall(function executor(resolve) {`
`9`	`9`	`resolve(5);`
`10`	`10`	`}));`
`11`	`11`
`12`	`12`	`// init hooks after promise was created`
`13`	`13`	`const hooks = initHooks({ allowNoInit: true });`
`14`	`14`	`hooks.enable();`
`15`	`15`
`16`		`-p.then(function afterresolution(val) {`
	`16`	`+p.then(function afterResolution(val) {`
`17`	`17`	`assert.strictEqual(val, 5);`
`18`	`18`	`const as = hooks.activitiesOfTypes('PROMISE');`
`19`	`19`	`assert.strictEqual(as.length, 1);`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.