GeezerVison is showing github.com — doc: clarify release process for new releasers · nodejs/node@2815bd3
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: doc/contributing/releases.md +16-1Lines changed: 16 additions & 1 deletion - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -468,7 +468,20 @@ failed build if you start again! |
468 | 468 | Jenkins collects the artifacts from the builds, allowing you to download and |
469 | 469 | install the new build. Make sure that the build appears correct. Check the |
470 | 470 | version numbers, and perform some basic checks to confirm that all is well with |
471 | | -the build before moving forward. |
| 471 | +the build before moving forward. Use the following list as a baseline: |
| 472 | + |
| 473 | +* `process.version` is as expected |
| 474 | +* `process.release` is as expected |
| 475 | +* `process.versions` is as expected (for example, `openssl` or `llhttp` version |
| 476 | + must be in the expected updated version) |
| 477 | +* npm version (check it matches what we expect) |
| 478 | +* Run the test suite against the built binaries (optional) |
| 479 | + |
| 480 | +```console |
| 481 | +./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node |
| 482 | +``` |
| 483 | + |
| 484 | +<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup> |
472 | 485 |
|
473 | 486 | ### 11. Tag and sign the release commit |
474 | 487 |
|
@@ -510,6 +523,8 @@ include the release code name. |
510 | 523 | The tag **must** be signed using the GPG key that's listed for you on the |
511 | 524 | project README. |
512 | 525 |
|
| 526 | +**Note**: Don't push the tag to remote at this point. |
| 527 | + |
513 | 528 | ### 12. Set up for the next release |
514 | 529 |
|
515 | 530 | On release proposal branch, edit `src/node_version.h` again and: |
|