GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: update crypo check rule · nodejs/node@2a85cc7

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- test-eslint-crypto-check.js
tools/eslint-rules
- crypto-check.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-eslint-crypto-check.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-eslint-crypto-check.js

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,14 @@ new RuleTester().run('crypto-check', rule, {`
`22`	`22`	`
`23`	`23`	`],`
`24`	`24`	`invalid: [`
	`25`	`+ {`
	`26`	`+ code: 'require("common")\n' +`
	`27`	`+ 'require("crypto")\n' +`
	`28`	`+ 'if (!common.hasCrypto) {\n' +`
	`29`	`+ ' common.skip("missing crypto");\n' +`
	`30`	`+ '}',`
	`31`	`+ errors: [{ message }]`
	`32`	`+ },`
`25`	`33`	`{`
`26`	`34`	`code: 'require("common")\n' +`
`27`	`35`	`'require("crypto")',`

Collapse file

`‎tools/eslint-rules/crypto-check.js‎`

Copy file name to clipboardExpand all lines: tools/eslint-rules/crypto-check.js

+16Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,22 @@ module.exports = function(context) {`
`66`	`66`
`67`	`67`	`function reportIfMissingCheck() {`
`68`	`68`	`if (hasSkipCall) {`
	`69`	`+ // There is a skip, which is good, but verify that the require() calls`
	`70`	`+ // in question come after at least one check.`
	`71`	`+ if (missingCheckNodes.length > 0) {`
	`72`	`+ requireNodes.forEach((requireNode) => {`
	`73`	`+ const beforeAllChecks = missingCheckNodes.every((checkNode) => {`
	`74`	`+ return requireNode.start < checkNode.start;`
	`75`	`+ });`
	`76`	`+`
	`77`	`+ if (beforeAllChecks) {`
	`78`	`+ context.report({`
	`79`	`+ node: requireNode,`
	`80`	`+ message: msg`
	`81`	`+ });`
	`82`	`+ }`
	`83`	`+ });`
	`84`	`+ }`
`69`	`85`	`return;`
`70`	`86`	`}`
`71`	`87`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.