GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: use ArrayBufferPrototypeGetByteLength · nodejs/node@2bde576

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/webstreams
- readablestream.js
- util.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/webstreams/readablestream.js‎`

Copy file name to clipboardExpand all lines: lib/internal/webstreams/readablestream.js

+8-8Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`const {`
`6`	`6`	`ArrayBuffer,`
	`7`	`+ ArrayBufferPrototypeGetByteLength,`
`7`	`8`	`ArrayBufferPrototypeSlice,`
`8`	`9`	`ArrayPrototypePush,`
`9`	`10`	`ArrayPrototypeShift,`
`@@ -93,7 +94,6 @@ const {`
`93`	`94`	`ArrayBufferViewGetBuffer,`
`94`	`95`	`ArrayBufferViewGetByteLength,`
`95`	`96`	`ArrayBufferViewGetByteOffset,`
`96`		`- ArrayBufferGetByteLength,`
`97`	`97`	`AsyncIterator,`
`98`	`98`	`cloneAsUint8Array,`
`99`	`99`	`copyArrayBuffer,`
`@@ -667,7 +667,7 @@ class ReadableStreamBYOBRequest {`
`667`	`667`
`668`	`668`	`const viewByteLength = ArrayBufferViewGetByteLength(view);`
`669`	`669`	`const viewBuffer = ArrayBufferViewGetBuffer(view);`
`670`		`- const viewBufferByteLength = ArrayBufferGetByteLength(viewBuffer);`
	`670`	`+ const viewBufferByteLength = ArrayBufferPrototypeGetByteLength(viewBuffer);`
`671`	`671`
`672`	`672`	`if (isDetachedBuffer(viewBuffer)) {`
`673`	`673`	`throw new ERR_INVALID_STATE.TypeError('Viewed ArrayBuffer is detached');`
`@@ -906,7 +906,7 @@ class ReadableStreamBYOBReader {`
`906`	`906`
`907`	`907`	`const viewByteLength = ArrayBufferViewGetByteLength(view);`
`908`	`908`	`const viewBuffer = ArrayBufferViewGetBuffer(view);`
`909`		`- const viewBufferByteLength = ArrayBufferGetByteLength(viewBuffer);`
	`909`	`+ const viewBufferByteLength = ArrayBufferPrototypeGetByteLength(viewBuffer);`
`910`	`910`
`911`	`911`	`if (viewByteLength === 0 \|\| viewBufferByteLength === 0) {`
`912`	`912`	`return PromiseReject(`
`@@ -1118,7 +1118,7 @@ class ReadableByteStreamController {`
`1118`	`1118`	`}`
`1119`	`1119`	`const chunkByteLength = ArrayBufferViewGetByteLength(chunk);`
`1120`	`1120`	`const chunkBuffer = ArrayBufferViewGetBuffer(chunk);`
`1121`		`- const chunkBufferByteLength = ArrayBufferGetByteLength(chunkBuffer);`
	`1121`	`+ const chunkBufferByteLength = ArrayBufferPrototypeGetByteLength(chunkBuffer);`
`1122`	`1122`	`if (chunkByteLength === 0 \|\| chunkBufferByteLength === 0) {`
`1123`	`1123`	`throw new ERR_INVALID_STATE.TypeError(`
`1124`	`1124`	`'chunk ArrayBuffer is zero-length or detached');`
`@@ -2492,7 +2492,7 @@ function readableByteStreamControllerPullInto(`
`2492`	`2492`	`const buffer = ArrayBufferViewGetBuffer(view);`
`2493`	`2493`	`const byteOffset = ArrayBufferViewGetByteOffset(view);`
`2494`	`2494`	`const byteLength = ArrayBufferViewGetByteLength(view);`
`2495`		`- const bufferByteLength = ArrayBufferGetByteLength(buffer);`
	`2495`	`+ const bufferByteLength = ArrayBufferPrototypeGetByteLength(buffer);`
`2496`	`2496`
`2497`	`2497`	`let transferredBuffer;`
`2498`	`2498`	`try {`
`@@ -2795,7 +2795,7 @@ function readableByteStreamControllerFillPullIntoDescriptorFromQueue(`
`2795`	`2795`	`totalBytesToCopyRemaining,`
`2796`	`2796`	`headOfQueue.byteLength);`
`2797`	`2797`	`const destStart = byteOffset + desc.bytesFilled;`
`2798`		`- const arrayBufferByteLength = ArrayBufferGetByteLength(buffer);`
	`2798`	`+ const arrayBufferByteLength = ArrayBufferPrototypeGetByteLength(buffer);`
`2799`	`2799`	`if (arrayBufferByteLength - destStart < bytesToCopy) {`
`2800`	`2800`	`throw new ERR_INVALID_STATE.RangeError(`
`2801`	`2801`	`'view ArrayBuffer size is invalid');`
`@@ -2899,7 +2899,7 @@ function readableByteStreamControllerRespondInReadableState(`
`2899`	`2899`	`controller,`
`2900`	`2900`	`remainder,`
`2901`	`2901`	`0,`
`2902`		`- ArrayBufferGetByteLength(remainder));`
	`2902`	`+ ArrayBufferPrototypeGetByteLength(remainder));`
`2903`	`2903`	`}`
`2904`	`2904`	`desc.bytesFilled -= remainderSize;`
`2905`	`2905`	`readableByteStreamControllerCommitPullIntoDescriptor(`
`@@ -2921,7 +2921,7 @@ function readableByteStreamControllerRespondWithNewView(controller, view) {`
`2921`	`2921`	`const viewByteLength = ArrayBufferViewGetByteLength(view);`
`2922`	`2922`	`const viewByteOffset = ArrayBufferViewGetByteOffset(view);`
`2923`	`2923`	`const viewBuffer = ArrayBufferViewGetBuffer(view);`
`2924`		`- const viewBufferByteLength = ArrayBufferGetByteLength(viewBuffer);`
	`2924`	`+ const viewBufferByteLength = ArrayBufferPrototypeGetByteLength(viewBuffer);`
`2925`	`2925`
`2926`	`2926`	`if (stream[kState].state === 'closed') {`
`2927`	`2927`	`if (viewByteLength !== 0)`

Collapse file

`‎lib/internal/webstreams/util.js‎`

Copy file name to clipboardExpand all lines: lib/internal/webstreams/util.js

+2-7Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`'use strict';`
`2`	`2`
`3`	`3`	`const {`
`4`		`- ArrayBufferPrototype,`
	`4`	`+ ArrayBufferPrototypeGetByteLength,`
`5`	`5`	`ArrayBufferPrototypeSlice,`
`6`	`6`	`ArrayPrototypePush,`
`7`	`7`	`ArrayPrototypeShift,`
`@@ -109,10 +109,6 @@ function ArrayBufferViewGetByteOffset(view) {`
`109`	`109`	`return ReflectGet(view.constructor.prototype, 'byteOffset', view);`
`110`	`110`	`}`
`111`	`111`
`112`		`-function ArrayBufferGetByteLength(view) {`
`113`		`- return ReflectGet(ArrayBufferPrototype, 'byteLength', view);`
`114`		`-}`
`115`		`-`
`116`	`112`	`function cloneAsUint8Array(view) {`
`117`	`113`	`const buffer = ArrayBufferViewGetBuffer(view);`
`118`	`114`	`const byteOffset = ArrayBufferViewGetByteOffset(view);`
`@@ -140,7 +136,7 @@ function transferArrayBuffer(buffer) {`
`140`	`136`	`}`
`141`	`137`
`142`	`138`	`function isDetachedBuffer(buffer) {`
`143`		`- if (ArrayBufferGetByteLength(buffer) === 0) {`
	`139`	`+ if (ArrayBufferPrototypeGetByteLength(buffer) === 0) {`
`144`	`140`	`// TODO(daeyeon): Consider using C++ builtin to improve performance.`
`145`	`141`	`try {`
`146`	`142`	`new Uint8Array(buffer);`
`@@ -244,7 +240,6 @@ module.exports = {`
`244`	`240`	`ArrayBufferViewGetBuffer,`
`245`	`241`	`ArrayBufferViewGetByteLength,`
`246`	`242`	`ArrayBufferViewGetByteOffset,`
`247`		`- ArrayBufferGetByteLength,`
`248`	`243`	`AsyncIterator,`
`249`	`244`	`cloneAsUint8Array,`
`250`	`245`	`copyArrayBuffer,`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.