GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: V8: backport 239898ef8c77 · nodejs/node@2d503ed

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

common.gypi
deps/v8/src
- codegen/riscv64
  - assembler-riscv64.cc
  - constants-riscv64.h
- execution/riscv64
  - simulator-riscv64.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎common.gypi‎`

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`
`37`	`37`	`# Reset this number to 0 on major V8 upgrades.`
`38`	`38`	`# Increment by one for each non-official patch applied to deps/v8.`
`39`		`- 'v8_embedder_string': '-node.20',`
	`39`	`+ 'v8_embedder_string': '-node.21',`
`40`	`40`
`41`	`41`	`##### V8 defaults for Node.js #####`
`42`	`42`

Collapse file

`‎deps/v8/src/codegen/riscv64/assembler-riscv64.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/riscv64/assembler-riscv64.cc

+7-7Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ static inline Instr SetJalrOffset(int32_t offset, Instr instr) {`
`461`	`461`	`instr &= ~kImm12Mask;`
`462`	`462`	`int32_t imm12 = offset << kImm12Shift;`
`463`	`463`	`DCHECK(Assembler::IsJalr(instr \| (imm12 & kImm12Mask)));`
`464`		`- DCHECK(Assembler::JalrOffset(instr \| (imm12 & kImm12Mask)) == offset);`
	`464`	`+ DCHECK_EQ(Assembler::JalrOffset(instr \| (imm12 & kImm12Mask)), offset);`
`465`	`465`	`return instr \| (imm12 & kImm12Mask);`
`466`	`466`	`}`
`467`	`467`
`@@ -702,7 +702,7 @@ int Assembler::BrachlongOffset(Instr auipc, Instr instr_I) {`
`702`	`702`	`InstructionBase::kIType);`
`703`	`703`	`DCHECK(IsAuipc(auipc));`
`704`	`704`	`int32_t imm_auipc = AuipcOffset(auipc);`
`705`		`- int32_t imm12 = (instr_I & kImm12Mask) >> 20;`
	`705`	`+ int32_t imm12 = static_cast<int32_t>(instr_I & kImm12Mask) >> 20;`
`706`	`706`	`int32_t offset = imm12 + imm_auipc;`
`707`	`707`	`return offset;`
`708`	`708`	`}`
`@@ -723,19 +723,19 @@ int Assembler::PatchBranchlongOffset(Address pc, Instr instr_auipc,`
`723`	`723`
`724`	`724`	`int Assembler::LdOffset(Instr instr) {`
`725`	`725`	`DCHECK(IsLd(instr));`
`726`		`- int32_t imm12 = (instr & kImm12Mask) >> 20;`
	`726`	`+ int32_t imm12 = static_cast<int32_t>(instr & kImm12Mask) >> 20;`
`727`	`727`	`return imm12;`
`728`	`728`	`}`
`729`	`729`
`730`	`730`	`int Assembler::JalrOffset(Instr instr) {`
`731`	`731`	`DCHECK(IsJalr(instr));`
`732`		`- int32_t imm12 = (instr & kImm12Mask) >> 20;`
	`732`	`+ int32_t imm12 = static_cast<int32_t>(instr & kImm12Mask) >> 20;`
`733`	`733`	`return imm12;`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`int Assembler::AuipcOffset(Instr instr) {`
`737`	`737`	`DCHECK(IsAuipc(instr));`
`738`		`- int32_t imm20 = instr & kImm20Mask;`
	`738`	`+ int32_t imm20 = static_cast<int32_t>(instr & kImm20Mask);`
`739`	`739`	`return imm20;`
`740`	`740`	`}`
`741`	`741`	`// We have to use a temporary register for things that can be relocated even`
`@@ -1277,7 +1277,7 @@ void Assembler::label_at_put(Label* L, int at_offset) {`
`1277`	`1277`	`DCHECK_EQ(imm18 & 3, 0);`
`1278`	`1278`	`int32_t imm16 = imm18 >> 2;`
`1279`	`1279`	`DCHECK(is_int16(imm16));`
`1280`		`- instr_at_put(at_offset, (imm16 & kImm16Mask));`
	`1280`	`+ instr_at_put(at_offset, (int32_t)(imm16 & kImm16Mask));`
`1281`	`1281`	`} else {`
`1282`	`1282`	`target_pos = kEndOfJumpChain;`
`1283`	`1283`	`instr_at_put(at_offset, target_pos);`
`@@ -2692,7 +2692,7 @@ void Assembler::GrowBuffer() {`
`2692`	`2692`	`reloc_info_writer.last_pc() + pc_delta);`
`2693`	`2693`
`2694`	`2694`	`// Relocate runtime entries.`
`2695`		`- Vector<byte> instructions{buffer_start_, pc_offset()};`
	`2695`	`+ Vector<byte> instructions{buffer_start_, static_cast<size_t>(pc_offset())};`
`2696`	`2696`	`Vector<const byte> reloc_info{reloc_info_writer.pos(), reloc_size};`
`2697`	`2697`	`for (RelocIterator it(instructions, reloc_info, 0); !it.done(); it.next()) {`
`2698`	`2698`	`RelocInfo::Mode rmode = it.rinfo()->rmode();`

Collapse file

`‎deps/v8/src/codegen/riscv64/constants-riscv64.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/riscv64/constants-riscv64.h

+36-36Lines changed: 36 additions & 36 deletions

Original file line number	Diff line number	Diff line change
`@@ -215,54 +215,54 @@ const int kRvcFunct6Shift = 10;`
`215`	`215`	`const int kRvcFunct6Bits = 6;`
`216`	`216`
`217`	`217`	`// RISCV Instruction bit masks`
`218`		`-const int kBaseOpcodeMask = ((1 << kBaseOpcodeBits) - 1) << kBaseOpcodeShift;`
`219`		`-const int kFunct3Mask = ((1 << kFunct3Bits) - 1) << kFunct3Shift;`
`220`		`-const int kFunct5Mask = ((1 << kFunct5Bits) - 1) << kFunct5Shift;`
`221`		`-const int kFunct7Mask = ((1 << kFunct7Bits) - 1) << kFunct7Shift;`
`222`		`-const int kFunct2Mask = 0b11 << kFunct7Shift;`
`223`		`-const int kRTypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct7Mask;`
`224`		`-const int kRATypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct5Mask;`
`225`		`-const int kRFPTypeMask = kBaseOpcodeMask \| kFunct7Mask;`
`226`		`-const int kR4TypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct2Mask;`
`227`		`-const int kITypeMask = kBaseOpcodeMask \| kFunct3Mask;`
`228`		`-const int kSTypeMask = kBaseOpcodeMask \| kFunct3Mask;`
`229`		`-const int kBTypeMask = kBaseOpcodeMask \| kFunct3Mask;`
`230`		`-const int kUTypeMask = kBaseOpcodeMask;`
`231`		`-const int kJTypeMask = kBaseOpcodeMask;`
`232`		`-const int kRs1FieldMask = ((1 << kRs1Bits) - 1) << kRs1Shift;`
`233`		`-const int kRs2FieldMask = ((1 << kRs2Bits) - 1) << kRs2Shift;`
`234`		`-const int kRs3FieldMask = ((1 << kRs3Bits) - 1) << kRs3Shift;`
`235`		`-const int kRdFieldMask = ((1 << kRdBits) - 1) << kRdShift;`
`236`		`-const int kBImm12Mask = kFunct7Mask \| kRdFieldMask;`
`237`		`-const int kImm20Mask = ((1 << kImm20Bits) - 1) << kImm20Shift;`
`238`		`-const int kImm12Mask = ((1 << kImm12Bits) - 1) << kImm12Shift;`
`239`		`-const int kImm11Mask = ((1 << kImm11Bits) - 1) << kImm11Shift;`
`240`		`-const int kImm31_12Mask = ((1 << 20) - 1) << 12;`
`241`		`-const int kImm19_0Mask = ((1 << 20) - 1);`
`242`		`-const int kRvcOpcodeMask =`
	`218`	`+const uint32_t kBaseOpcodeMask = ((1 << kBaseOpcodeBits) - 1) << kBaseOpcodeShift;`
	`219`	`+const uint32_t kFunct3Mask = ((1 << kFunct3Bits) - 1) << kFunct3Shift;`
	`220`	`+const uint32_t kFunct5Mask = ((1 << kFunct5Bits) - 1) << kFunct5Shift;`
	`221`	`+const uint32_t kFunct7Mask = ((1 << kFunct7Bits) - 1) << kFunct7Shift;`
	`222`	`+const uint32_t kFunct2Mask = 0b11 << kFunct7Shift;`
	`223`	`+const uint32_t kRTypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct7Mask;`
	`224`	`+const uint32_t kRATypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct5Mask;`
	`225`	`+const uint32_t kRFPTypeMask = kBaseOpcodeMask \| kFunct7Mask;`
	`226`	`+const uint32_t kR4TypeMask = kBaseOpcodeMask \| kFunct3Mask \| kFunct2Mask;`
	`227`	`+const uint32_t kITypeMask = kBaseOpcodeMask \| kFunct3Mask;`
	`228`	`+const uint32_t kSTypeMask = kBaseOpcodeMask \| kFunct3Mask;`
	`229`	`+const uint32_t kBTypeMask = kBaseOpcodeMask \| kFunct3Mask;`
	`230`	`+const uint32_t kUTypeMask = kBaseOpcodeMask;`
	`231`	`+const uint32_t kJTypeMask = kBaseOpcodeMask;`
	`232`	`+const uint32_t kRs1FieldMask = ((1 << kRs1Bits) - 1) << kRs1Shift;`
	`233`	`+const uint32_t kRs2FieldMask = ((1 << kRs2Bits) - 1) << kRs2Shift;`
	`234`	`+const uint32_t kRs3FieldMask = ((1 << kRs3Bits) - 1) << kRs3Shift;`
	`235`	`+const uint32_t kRdFieldMask = ((1 << kRdBits) - 1) << kRdShift;`
	`236`	`+const uint32_t kBImm12Mask = kFunct7Mask \| kRdFieldMask;`
	`237`	`+const uint32_t kImm20Mask = ((1 << kImm20Bits) - 1) << kImm20Shift;`
	`238`	`+const uint32_t kImm12Mask = ((1 << kImm12Bits) - 1) << kImm12Shift;`
	`239`	`+const uint32_t kImm11Mask = ((1 << kImm11Bits) - 1) << kImm11Shift;`
	`240`	`+const uint32_t kImm31_12Mask = ((1 << 20) - 1) << 12;`
	`241`	`+const uint32_t kImm19_0Mask = ((1 << 20) - 1);`
	`242`	`+const uint32_t kRvcOpcodeMask =`
`243`	`243`	`0b11 \| (((1 << kRvcFunct3Bits) - 1) << kRvcFunct3Shift);`
`244`		`-const int kRvcFunct3Mask = (((1 << kRvcFunct3Bits) - 1) << kRvcFunct3Shift);`
`245`		`-const int kRvcFunct4Mask = (((1 << kRvcFunct4Bits) - 1) << kRvcFunct4Shift);`
`246`		`-const int kRvcFunct6Mask = (((1 << kRvcFunct6Bits) - 1) << kRvcFunct6Shift);`
`247`		`-const int kRvcFunct2Mask = (((1 << kRvcFunct2Bits) - 1) << kRvcFunct2Shift);`
`248`		`-const int kCRTypeMask = kRvcOpcodeMask \| kRvcFunct4Mask;`
`249`		`-const int kCSTypeMask = kRvcOpcodeMask \| kRvcFunct6Mask;`
`250`		`-const int kCATypeMask = kRvcOpcodeMask \| kRvcFunct6Mask \| kRvcFunct2Mask;`
	`244`	`+const uint32_t kRvcFunct3Mask = (((1 << kRvcFunct3Bits) - 1) << kRvcFunct3Shift);`
	`245`	`+const uint32_t kRvcFunct4Mask = (((1 << kRvcFunct4Bits) - 1) << kRvcFunct4Shift);`
	`246`	`+const uint32_t kRvcFunct6Mask = (((1 << kRvcFunct6Bits) - 1) << kRvcFunct6Shift);`
	`247`	`+const uint32_t kRvcFunct2Mask = (((1 << kRvcFunct2Bits) - 1) << kRvcFunct2Shift);`
	`248`	`+const uint32_t kCRTypeMask = kRvcOpcodeMask \| kRvcFunct4Mask;`
	`249`	`+const uint32_t kCSTypeMask = kRvcOpcodeMask \| kRvcFunct6Mask;`
	`250`	`+const uint32_t kCATypeMask = kRvcOpcodeMask \| kRvcFunct6Mask \| kRvcFunct2Mask;`
`251`	`251`
`252`	`252`	`// RISCV CSR related bit mask and shift`
`253`	`253`	`const int kFcsrFlagsBits = 5;`
`254`		`-const int kFcsrFlagsMask = (1 << kFcsrFlagsBits) - 1;`
	`254`	`+const uint32_t kFcsrFlagsMask = (1 << kFcsrFlagsBits) - 1;`
`255`	`255`	`const int kFcsrFrmBits = 3;`
`256`	`256`	`const int kFcsrFrmShift = kFcsrFlagsBits;`
`257`		`-const int kFcsrFrmMask = ((1 << kFcsrFrmBits) - 1) << kFcsrFrmShift;`
	`257`	`+const uint32_t kFcsrFrmMask = ((1 << kFcsrFrmBits) - 1) << kFcsrFrmShift;`
`258`	`258`	`const int kFcsrBits = kFcsrFlagsBits + kFcsrFrmBits;`
`259`		`-const int kFcsrMask = kFcsrFlagsMask \| kFcsrFrmMask;`
	`259`	`+const uint32_t kFcsrMask = kFcsrFlagsMask \| kFcsrFrmMask;`
`260`	`260`
`261`	`261`	`// Original MIPS constants`
`262`	`262`	`// TODO(RISCV): to be cleaned up`
`263`	`263`	`const int kImm16Shift = 0;`
`264`	`264`	`const int kImm16Bits = 16;`
`265`		`-const int kImm16Mask = ((1 << kImm16Bits) - 1) << kImm16Shift;`
	`265`	`+const uint32_t kImm16Mask = ((1 << kImm16Bits) - 1) << kImm16Shift;`
`266`	`266`	`// end of TODO(RISCV): to be cleaned up`
`267`	`267`
`268`	`268`	`// ----- RISCV Base Opcodes`

Collapse file

`‎deps/v8/src/execution/riscv64/simulator-riscv64.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/execution/riscv64/simulator-riscv64.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1842,7 +1842,7 @@ float Simulator::RoundF2FHelper(float input_val, int rmode) {`
`1842`	`1842`	`float rounded = 0;`
`1843`	`1843`	`switch (rmode) {`
`1844`	`1844`	`case RNE: { // Round to Nearest, tiest to Even`
`1845`		`- rounded = std::floorf(input_val);`
	`1845`	`+ rounded = floorf(input_val);`
`1846`	`1846`	`float error = input_val - rounded;`
`1847`	`1847`
`1848`	`1848`	`// Take care of correctly handling the range [-0.5, -0.0], which must`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.