GeezerVison is showing github.com — dns: simplify dns.promises warning logic · nodejs/node@2dfaa48
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: lib/dns.js +3-5Lines changed: 3 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -50,8 +50,7 @@ const { |
50 | 50 |
|
51 | 51 | const dnsException = errors.dnsException; |
52 | 52 |
|
53 | | -let promisesWarn = true; |
54 | | -let promises; // Lazy loaded |
| 53 | +let promises = null; // Lazy loaded |
55 | 54 |
|
56 | 55 | function onlookup(err, addresses) { |
57 | 56 | if (err) { |
@@ -269,7 +268,7 @@ function defaultResolverSetServers(servers) { |
269 | 268 | setDefaultResolver(resolver); |
270 | 269 | bindDefaultResolver(module.exports, Resolver.prototype); |
271 | 270 |
|
272 | | - if (promises !== undefined) |
| 271 | + if (promises !== null) |
273 | 272 | bindDefaultResolver(promises, promises.Resolver.prototype); |
274 | 273 | } |
275 | 274 |
|
@@ -318,10 +317,9 @@ Object.defineProperties(module.exports, { |
318 | 317 | configurable: true, |
319 | 318 | enumerable: false, |
320 | 319 | get() { |
321 | | - if (promisesWarn) { |
| 320 | + if (promises === null) { |
322 | 321 | promises = require('internal/dns/promises'); |
323 | 322 | promises.setServers = defaultResolverSetServers; |
324 | | - promisesWarn = false; |
325 | 323 | process.emitWarning('The dns.promises API is experimental', |
326 | 324 | 'ExperimentalWarning'); |
327 | 325 | } |
|