GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: fix release proposal linter to support more than 1 folk preparing · nodejs/node@2e76cd2

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

.github/workflows
- lint-release-proposal.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎.github/workflows/lint-release-proposal.yml‎`

Copy file name to clipboardExpand all lines: .github/workflows/lint-release-proposal.yml

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ jobs:`
`43`	`43`	`PR_HEAD="$(gh pr view "$PR_URL" --json headRefOid -q .headRefOid)"`
`44`	`44`	`echo "Head of $PR_URL: $PR_HEAD"`
`45`	`45`	`echo "Current commit: $GITHUB_SHA"`
`46`		`- [[ "$PR_HEAD" == "$GITHUB_SHA" ]]`
	`46`	`+ [ "$PR_HEAD" = "$GITHUB_SHA" ]`
`47`	`47`	`env:`
`48`	`48`	`GH_TOKEN: ${{ github.token }}`
`49`	`49`	`- name: Validate CHANGELOG`
`@@ -53,7 +53,7 @@ jobs:`
`53`	`53`	`echo "Expected CHANGELOG section title: $EXPECTED_CHANGELOG_TITLE_INTRO"`
`54`	`54`	`CHANGELOG_TITLE="$(grep "$EXPECTED_CHANGELOG_TITLE_INTRO" "doc/changelogs/CHANGELOG_V${COMMIT_SUBJECT:20:2}.md")"`
`55`	`55`	`echo "Actual: $CHANGELOG_TITLE"`
`56`		`- [[ "${CHANGELOG_TITLE%@*}@" == "$EXPECTED_CHANGELOG_TITLE_INTRO" ]]`
	`56`	`+ [ "${CHANGELOG_TITLE%%@*}@" = "$EXPECTED_CHANGELOG_TITLE_INTRO" ]`
`57`	`57`	`- name: Verify NODE_VERSION_IS_RELEASE bit is correctly set`
`58`	`58`	`run: \|`
`59`	`59`	`grep -q '^#define NODE_VERSION_IS_RELEASE 1$' src/node_version.h`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.