GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: V8: cherry-pick f9257802c1c0 · nodejs/node@2e92cb4

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

common.gypi
deps/v8
- src/parsing
- test/message/fail
  - hashbang-incomplete-string.js
  - hashbang-incomplete-string.out

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎common.gypi‎`

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`
`35`	`35`	`# Reset this number to 0 on major V8 upgrades.`
`36`	`36`	`# Increment by one for each non-official patch applied to deps/v8.`
`37`		`- 'v8_embedder_string': '-node.34',`
	`37`	`+ 'v8_embedder_string': '-node.35',`
`38`	`38`
`39`	`39`	`##### V8 defaults for Node.js #####`
`40`	`40`

Collapse file

`‎deps/v8/src/parsing/parser.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/parsing/parser.cc

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,6 @@ FunctionLiteral* Parser::ParseProgram(Isolate* isolate, ParseInfo* info) {`
`502`	`502`	`Scope::DeserializationMode::kIncludingVariables);`
`503`	`503`
`504`	`504`	`scanner_.Initialize();`
`505`		`- scanner_.SkipHashBang();`
`506`	`505`	`FunctionLiteral* result = DoParseProgram(isolate, info);`
`507`	`506`	`MaybeResetCharacterStream(info, result);`
`508`	`507`	`MaybeProcessSourceRanges(info, result, stack_limit_);`

Collapse file

`‎deps/v8/src/parsing/preparser.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/parsing/preparser.cc

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,6 @@ PreParser::PreParseResult PreParser::PreParseProgram() {`
`74`	`74`	`scope->set_is_being_lazily_parsed(true);`
`75`	`75`	`#endif`
`76`	`76`
`77`		`- // Note: We should only skip the hashbang in non-Eval scripts`
`78`		`- // (currently, Eval is not handled by the PreParser).`
`79`		`- scanner()->SkipHashBang();`
`80`		`-`
`81`	`77`	`// ModuleDeclarationInstantiation for Source Text Module Records creates a`
`82`	`78`	`// new Module Environment Record whose outer lexical environment record is`
`83`	`79`	`// the global scope.`

Collapse file

`‎deps/v8/src/parsing/scanner-inl.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/parsing/scanner-inl.h

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -505,6 +505,10 @@ V8_INLINE Token::Value Scanner::ScanSingleToken() {`
`505`	`505`	`return ScanTemplateSpan();`
`506`	`506`
`507`	`507`	`case Token::PRIVATE_NAME:`
	`508`	`+ if (source_pos() == 0 && Peek() == '!') {`
	`509`	`+ token = SkipSingleLineComment();`
	`510`	`+ continue;`
	`511`	`+ }`
`508`	`512`	`return ScanPrivateName();`
`509`	`513`
`510`	`514`	`case Token::WHITESPACE:`

Collapse file

`‎deps/v8/src/parsing/scanner.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/parsing/scanner.cc

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -314,13 +314,6 @@ Token::Value Scanner::SkipMultiLineComment() {`
`314`	`314`	`return Token::ILLEGAL;`
`315`	`315`	`}`
`316`	`316`
`317`		`-void Scanner::SkipHashBang() {`
`318`		`- if (c0_ == '#' && Peek() == '!' && source_pos() == 0) {`
`319`		`- SkipSingleLineComment();`
`320`		`- Scan();`
`321`		`- }`
`322`		`-}`
`323`		`-`
`324`	`317`	`Token::Value Scanner::ScanHtmlComment() {`
`325`	`318`	`// Check for <!-- comments.`
`326`	`319`	`DCHECK_EQ(c0_, '!');`

Collapse file

`‎deps/v8/src/parsing/scanner.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/parsing/scanner.h

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -420,9 +420,6 @@ class V8_EXPORT_PRIVATE Scanner {`
`420`	`420`
`421`	`421`	`const Utf16CharacterStream* stream() const { return source_; }`
`422`	`422`
`423`		`- // If the next characters in the stream are "#!", the line is skipped.`
`424`		`- void SkipHashBang();`
`425`		`-`
`426`	`423`	`private:`
`427`	`424`	`// Scoped helper for saving & restoring scanner error state.`
`428`	`425`	`// This is used for tagged template literals, in which normally forbidden`

Collapse file

`‎deps/v8/test/message/fail/hashbang-incomplete-string.js‎`

Copy file name to clipboard

+12Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,12 @@`
	`1`	`+#!/usr/bin/env d8`
	`2`	`+// Copyright 2015 the V8 project authors. All rights reserved.`
	`3`	`+// Use of this source code is governed by a BSD-style license that can be`
	`4`	`+// found in the LICENSE file.`
	`5`	`+//`
	`6`	`+//`
	`7`	`+`
	`8`	`+const x = 'valid code';`
	`9`	`+`
	`10`	`+'incomplete string`
	`11`	`+`
	`12`	`+const y = 'even more valid code!';`

Collapse file

`‎deps/v8/test/message/fail/hashbang-incomplete-string.out‎`

Copy file name to clipboard

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+*%(basename)s:10: SyntaxError: Invalid or unexpected token`
	`2`	`+'incomplete string`
	`3`	`+^^^^^^^^^^^^^^^^^^`
	`4`	`+`
	`5`	`+SyntaxError: Invalid or unexpected token`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.