GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: fix test-net-settimeout flakiness · nodejs/node@37cc249

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- test-net-settimeout.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-net-settimeout.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-net-settimeout.js

+11-9Lines changed: 11 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,22 +8,24 @@ const assert = require('assert');`
`8`	`8`
`9`	`9`	`const T = 100;`
`10`	`10`
`11`		`-const server = net.createServer(function(c) {`
	`11`	`+const server = net.createServer(common.mustCall((c) => {`
`12`	`12`	`c.write('hello');`
`13`		`-});`
	`13`	`+}));`
	`14`	`+`
`14`	`15`	`server.listen(common.PORT);`
`15`	`16`
`16`	`17`	`const socket = net.createConnection(common.PORT, 'localhost');`
`17`	`18`
`18`		`-const s = socket.setTimeout(T, function() {`
	`19`	`+const s = socket.setTimeout(T, () => {`
`19`	`20`	`common.fail('Socket timeout event is not expected to fire');`
`20`	`21`	`});`
`21`	`22`	`assert.ok(s instanceof net.Socket);`
`22`	`23`
`23`		`-socket.setTimeout(0);`
`24`		`-`
`25`		`-setTimeout(function() {`
`26`		`- socket.destroy();`
`27`		`- server.close();`
`28`		`-}, T * 2);`
	`24`	`+socket.on('data', common.mustCall(() => {`
	`25`	`+ setTimeout(function() {`
	`26`	`+ socket.destroy();`
	`27`	`+ server.close();`
	`28`	`+ }, T * 2);`
	`29`	`+}));`
`29`	`30`
	`31`	`+socket.setTimeout(0);`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.