GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — events: check signal before listener · nodejs/node@3dcdab3

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal
- event_target.js
test/wpt/status/dom
- events.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/event_target.js‎`

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -561,6 +561,8 @@ class EventTarget {`
`561`	`561`	`weak,`
`562`	`562`	`} = validateEventListenerOptions(options);`
`563`	`563`
	`564`	`+ validateAbortSignal(signal, 'options.signal');`
	`565`	`+`
`564`	`566`	`if (!validateEventListener(listener)) {`
`565`	`567`	`// The DOM silently allows passing undefined as a second argument`
`566`	`568`	`// No error code for this since it is a Warning`
`@@ -575,8 +577,6 @@ class EventTarget {`
`575`	`577`	`}`
`576`	`578`	`type = String(type);`
`577`	`579`
`578`		`- validateAbortSignal(signal, 'options.signal');`
`579`		`-`
`580`	`580`	`if (signal) {`
`581`	`581`	`if (signal.aborted) {`
`582`	`582`	`return;`

Collapse file

`‎test/wpt/status/dom/events.json‎`

Copy file name to clipboardExpand all lines: test/wpt/status/dom/events.json

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,13 +8,6 @@`
`8`	`8`	`]`
`9`	`9`	`}`
`10`	`10`	`},`
`11`		`- "AddEventListenerOptions-signal.any.js": {`
`12`		`- "fail": {`
`13`		`- "expected": [`
`14`		`- "Passing null as the signal should throw (listener is also null)"`
`15`		`- ]`
`16`		`- }`
`17`		`- },`
`18`	`11`	`"Event-constructors.any.js": {`
`19`	`12`	`"fail": {`
`20`	`13`	`"expected": [`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.