GeezerVison is showing github.com — doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc · nodejs/node@3f771ca
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: doc/contributing/releases-node-api.md +3-3Lines changed: 3 additions & 3 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -9,7 +9,7 @@ release process. |
9 | 9 | * [0. Pre-release steps](#0-pre-release-steps) |
10 | 10 | * [1. Update the main branch](#1-update-the-main-branch) |
11 | 11 | * [2. Create a new branch for the release](#2-create-a-new-branch-for-the-release) |
12 | | - * [3. Update `NAPI_VERSION`](#3-update-napi_version) |
| 12 | + * [3. Update `NODE_API_SUPPORTED_VERSION_MAX`](#3-update-node_api_supported_version_max) |
13 | 13 | * [4. Define `addon_context_register_func`](#4-define-addon_context_register_func) |
14 | 14 | * [5. Update version guards](#5-update-version-guards) |
15 | 15 | * [6. Create release commit](#6-create-release-commit) |
@@ -55,13 +55,13 @@ Create a new branch named `node-api-x-proposal`, off the main branch. |
55 | 55 | $ git checkout -b node-api-10-proposal upstream/main |
56 | 56 | ``` |
57 | 57 |
|
58 | | -### 3. Update `NAPI_VERSION` |
| 58 | +### 3. Update `NODE_API_SUPPORTED_VERSION_MAX` |
59 | 59 |
|
60 | 60 | Set the version for the proposed release using the following macros, which are |
61 | 61 | already defined in `src/node_version.h`: |
62 | 62 |
|
63 | 63 | ```c |
64 | | -#define NAPI_VERSION x |
| 64 | +#define NODE_API_SUPPORTED_VERSION_MAX x |
65 | 65 | ``` |
66 | 66 |
|
67 | 67 | > Note: Do not update the `NAPI_VERSION` defined in `src/js_native_api.h`. It |
|