GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — meta: clarify pr objection process further · nodejs/node@41b4f4d

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/contributing
- collaborator-guide.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/contributing/collaborator-guide.md‎`

Copy file name to clipboardExpand all lines: doc/contributing/collaborator-guide.md

+23-5Lines changed: 23 additions & 5 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -154,10 +154,13 @@ requirements. If a pull request meets all requirements except the`
`154`	`154`
`155`	`155`	`Collaborators can object to a pull request by using the "Request`
`156`	`156`	`Changes" GitHub feature. Dissent comments alone don't constitute an`
`157`		`-objection. Any pull request objection must include a clear reason for that`
`158`		`-objection, and the objector must remain responsive for further discussion`
`159`		`-towards consensus about the direction of the pull request. Where possible,`
`160`		`-provide a set of actionable steps alongside the objection.`
	`157`	`+objection, nor do dissenting comments made in any associated issue.`
	`158`	`+A blocking objection to a change must be made in the pull request that`
	`159`	`+specifically proposes that change. Any pull request objection must include`
	`160`	`+a clear reason for that objection, and the objector must remain responsive`
	`161`	`+for further discussion towards consensus about the direction of the pull`
	`162`	`+request. Where possible, provide a set of actionable steps alongside the`
	`163`	`+objection.`
`161`	`164`
`162`	`165`	`If the objection is not clear to others, another collaborator can ask an`
`163`	`166`	`objecting collaborator to explain their objection or to provide actionable`
`@@ -168,7 +171,22 @@ dismiss the objection.`
`168`	`171`	`Pull requests with outstanding objections must remain open until all`
`169`	`172`	`objections are satisfied. If reaching consensus is not possible, a`
`170`	`173`	collaborator can escalate the issue to the TSC by pinging `@nodejs/tsc` and
`171`		-adding the `tsc-agenda` label to the issue.
	`174`	+adding the `tsc-agenda` label to the issue. The change cannot proceed without
	`175`	`+either reaching consensus or a TSC decision to dismiss the objection(s). If the`
	`176`	`+TSC does choose to dismiss any objections, a clear explanation of the reasoning`
	`177`	`+or a link to the public vote must be given in the pull request before it lands.`
	`178`	`+`
	`179`	`+All Collaborator objections are considered equal. There is no greater weight given to`
	`180`	`+objections from TSC members than from any other Collaborator.`
	`181`	`+`
	`182`	`+Mistakes do happen. If a pull request is merged with an unresolved objection,`
	`183`	`+submit a fix. Simple issues may be fixed with a follow-up PR that addresses`
	`184`	`+the concern. More difficult issues may require a full revert. Most corrections`
	`185`	`+can be fast-tracked. If deemed necessary take a slower route to ensure stability`
	`186`	`+and consensus.`
	`187`	`+`
	`188`	`+Collaborators objecting to a pull request can best ensure their objections`
	`189`	`+are addressed by remaining engaged and responsive in the discussion.`
`172`	`190`
`173`	`191`	`#### Helpful resources`
`174`	`192`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.