GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — lib: remove invalid parameter to toASCII · nodejs/node@420b85c

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- url.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/url.js‎`

Copy file name to clipboardExpand all lines: lib/url.js

+1-4Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -401,10 +401,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {`
`401`	`401`	`// It only converts parts of the domain name that`
`402`	`402`	`// have non-ASCII characters, i.e. it doesn't matter if`
`403`	`403`	`// you call it with a domain that already is ASCII-only.`
`404`		`-`
`405`		- // Use lenient mode (`true`) to try to support even non-compliant
`406`		`- // URLs.`
`407`		`- this.hostname = toASCII(this.hostname, true);`
	`404`	`+ this.hostname = toASCII(this.hostname);`
`408`	`405`
`409`	`406`	`// Prevent two potential routes of hostname spoofing.`
`410`	`407`	`// 1. If this.hostname is empty, it must have become empty due to toASCII`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.