GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http2: move events to the JSStreamSocket · nodejs/node@429113e

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib/internal/http2
    • core.js
  • test/parallel
    • test-http2-client-jsstream-destroy.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/internal/http2/core.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/core.js
+6-3Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3132,11 +3132,14 @@ function connect(authority, options, listener) {
31323132
}
31333133
}
31343134

3135-
socket.on('error', socketOnError);
3136-
socket.on('close', socketOnClose);
3137-
31383135
const session = new ClientHttp2Session(options, socket);
31393136

3137+
// ClientHttp2Session may create a new socket object
3138+
// when socket is a JSSocket (socket != kSocket)
3139+
// https://github.com/nodejs/node/issues/35695
3140+
session[kSocket].on('error', socketOnError);
3141+
session[kSocket].on('close', socketOnClose);
3142+
31403143
session[kAuthority] = `${options.servername || host}:${port}`;
31413144
session[kProtocol] = protocol;
31423145

Collapse file

‎test/parallel/test-http2-client-jsstream-destroy.js‎

Copy file name to clipboard
+55Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
if (!common.hasCrypto)
5+
common.skip('missing crypto');
6+
const h2 = require('http2');
7+
const tls = require('tls');
8+
const fixtures = require('../common/fixtures');
9+
const { Duplex } = require('stream');
10+
11+
const server = h2.createSecureServer({
12+
key: fixtures.readKey('agent1-key.pem'),
13+
cert: fixtures.readKey('agent1-cert.pem')
14+
});
15+
16+
class JSSocket extends Duplex {
17+
constructor(socket) {
18+
super({ emitClose: true });
19+
socket.on('close', () => this.destroy());
20+
socket.on('data', (data) => this.push(data));
21+
this.socket = socket;
22+
}
23+
24+
_write(data, encoding, callback) {
25+
this.socket.write(data, encoding, callback);
26+
}
27+
28+
_read(size) {
29+
}
30+
31+
_final(cb) {
32+
cb();
33+
}
34+
}
35+
36+
server.listen(0, common.mustCall(function() {
37+
const socket = tls.connect({
38+
rejectUnauthorized: false,
39+
host: 'localhost',
40+
port: this.address().port,
41+
ALPNProtocols: ['h2']
42+
}, () => {
43+
const proxy = new JSSocket(socket);
44+
const client = h2.connect(`https://localhost:${this.address().port}`, {
45+
createConnection: () => proxy
46+
});
47+
const req = client.request();
48+
49+
setTimeout(() => socket.destroy(), 200);
50+
setTimeout(() => client.close(), 400);
51+
setTimeout(() => server.close(), 600);
52+
53+
req.on('close', common.mustCall(() => { }));
54+
});
55+
}));

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.