GeezerVison is showing github.com — build: sync V8 warning cflags with BUILD.gn · nodejs/node@4573231
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: common.gypi -1Lines changed: 0 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
| 3 | 3 | 'configuring_node%': 0, | 4 | 4 | 'asan%': 0, | 5 | 5 | 'ubsan%': 0, | 6 | | - 'werror': '', # Turn off -Werror in V8 build. | 7 | 6 | 'visibility%': 'hidden', # V8's visibility setting | 8 | 7 | 'target_arch%': 'ia32', # set v8's target architecture | 9 | 8 | 'host_arch%': 'ia32', # set v8's host architecture | |
Collapse file Copy file name to clipboardExpand all lines: tools/v8_gypfiles/toolchain.gypi +12-8Lines changed: 12 additions & 8 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 82 | 82 | 'v8_toolset_for_shell%': 'target', | 83 | 83 |
| 84 | 84 | 'host_os%': '<(OS)', | 85 | | - 'werror%': '-Werror', | 86 | 85 | # For a shared library build, results in "libv8-<(soname_version).so". | 87 | 86 | 'soname_version%': '', | 88 | 87 |
| | 133 | 132 | '<(V8_ROOT)', | 134 | 133 | '<(V8_ROOT)/include', | 135 | 134 | ], | | 135 | + 'cflags!': ['-Wall', '-Wextra'], | 136 | 136 | 'conditions': [ | 137 | | - ['clang==1', { | 138 | | - 'cflags': [ '-Werror', '-Wno-unknown-pragmas' ], | 139 | | - },{ | 140 | | - 'cflags!': [ '-Wall', '-Wextra' ], | | 137 | + ['clang==0 and OS!="win"', { | 141 | 138 | 'cflags': [ | | 139 | + # In deps/v8/BUILD.gn: if (!is_clang && !is_win) { cflags += [...] } | | 140 | + '-Wno-strict-overflow', | 142 | 141 | '-Wno-return-type', | | 142 | + '-Wno-int-in-bool-context', | | 143 | + '-Wno-deprecated', | | 144 | + '-Wno-stringop-overflow', | | 145 | + '-Wno-stringop-overread', | | 146 | + '-Wno-restrict', | | 147 | + '-Wno-array-bounds', | | 148 | + '-Wno-nonnull', | | 149 | + '-Wno-dangling-pointer', | 143 | 150 | # On by default in Clang and V8 requires it at least for arm64. | 144 | 151 | '-flax-vector-conversions', | 145 | 152 | ], | | 428 | 435 | ['_toolset=="target"', { | 429 | 436 | 'conditions': [ | 430 | 437 | ['v8_target_arch==target_arch', { | 431 | | - 'cflags': [ | 432 | | - '-Wno-error=array-bounds', # Workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273 | 433 | | - ], | 434 | 438 | 'conditions': [ | 435 | 439 | ['v8_target_arch=="mips64el"', { | 436 | 440 | 'cflags': ['-EL'], | |
Collapse file Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp -6Lines changed: 0 additions & 6 deletions | Original file line number | Diff line number | Diff line change |
|---|
| 1981 | 1981 | ] | 1982 | 1982 | }], | 1983 | 1983 | ], | 1984 | | - # -Wno-invalid-offsetof flag is not valid for C. | 1985 | | - # The flag is initially set in `toolchain.gypi` for all targets. | 1986 | | - 'cflags!': [ '-Wno-invalid-offsetof' ], | 1987 | | - 'xcode_settings': { | 1988 | | - 'WARNING_CFLAGS!': ['-Wno-invalid-offsetof'] | 1989 | | - }, | 1990 | 1984 | 'direct_dependent_settings': { | 1991 | 1985 | 'include_dirs': [ | 1992 | 1986 | '<(V8_ROOT)/third_party/zlib', | |
|