GeezerVison is showing github.com — src: simplify IsolateData shortcut accesses · nodejs/node@46e68bb
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/env-inl.h +3-4Lines changed: 3 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -1227,9 +1227,8 @@ int64_t Environment::base_object_count() const { |
1227 | 1227 | #define VS(PropertyName, StringValue) V(v8::String, PropertyName) |
1228 | 1228 | #define V(TypeName, PropertyName) \ |
1229 | 1229 | inline \ |
1230 | | - v8::Local<TypeName> IsolateData::PropertyName(v8::Isolate* isolate) const { \ |
1231 | | - /* Strings are immutable so casting away const-ness here is okay. */ \ |
1232 | | - return const_cast<IsolateData*>(this)->PropertyName ## _.Get(isolate); \ |
| 1230 | + v8::Local<TypeName> IsolateData::PropertyName() const { \ |
| 1231 | + return PropertyName ## _ .Get(isolate_); \ |
1233 | 1232 | } |
1234 | 1233 | PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(VP) |
1235 | 1234 | PER_ISOLATE_SYMBOL_PROPERTIES(VY) |
@@ -1244,7 +1243,7 @@ int64_t Environment::base_object_count() const { |
1244 | 1243 | #define VS(PropertyName, StringValue) V(v8::String, PropertyName) |
1245 | 1244 | #define V(TypeName, PropertyName) \ |
1246 | 1245 | inline v8::Local<TypeName> Environment::PropertyName() const { \ |
1247 | | - return isolate_data()->PropertyName(isolate()); \ |
| 1246 | + return isolate_data()->PropertyName(); \ |
1248 | 1247 | } |
1249 | 1248 | PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(VP) |
1250 | 1249 | PER_ISOLATE_SYMBOL_PROPERTIES(VY) |
|
Collapse file
Copy file name to clipboardExpand all lines: src/env.cc +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -181,12 +181,12 @@ IsolateData::IsolateData(Isolate* isolate, |
181 | 181 |
|
182 | 182 | void IsolateData::MemoryInfo(MemoryTracker* tracker) const { |
183 | 183 | #define V(PropertyName, StringValue) \ |
184 | | - tracker->TrackField(#PropertyName, PropertyName(isolate())); |
| 184 | + tracker->TrackField(#PropertyName, PropertyName()); |
185 | 185 | PER_ISOLATE_SYMBOL_PROPERTIES(V) |
186 | 186 | #undef V |
187 | 187 |
|
188 | 188 | #define V(PropertyName, StringValue) \ |
189 | | - tracker->TrackField(#PropertyName, PropertyName(isolate())); |
| 189 | + tracker->TrackField(#PropertyName, PropertyName()); |
190 | 190 | PER_ISOLATE_STRING_PROPERTIES(V) |
191 | 191 | #undef V |
192 | 192 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: src/env.h +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -502,7 +502,7 @@ class IsolateData : public MemoryRetainer { |
502 | 502 | #define VY(PropertyName, StringValue) V(v8::Symbol, PropertyName) |
503 | 503 | #define VS(PropertyName, StringValue) V(v8::String, PropertyName) |
504 | 504 | #define V(TypeName, PropertyName) \ |
505 | | - inline v8::Local<TypeName> PropertyName(v8::Isolate* isolate) const; |
| 505 | + inline v8::Local<TypeName> PropertyName() const; |
506 | 506 | PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(VP) |
507 | 507 | PER_ISOLATE_SYMBOL_PROPERTIES(VY) |
508 | 508 | PER_ISOLATE_STRING_PROPERTIES(VS) |
|