GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — net: validate non-string host for socket.connect · nodejs/node@4762f4a

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- net.js
test/parallel
- test-net-connect-options-invalid.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/net.js‎`

Copy file name to clipboardExpand all lines: lib/net.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1311,6 +1311,8 @@ function lookupAndConnect(self, options) {`
`1311`	`1311`	`const host = options.host \|\| 'localhost';`
`1312`	`1312`	`let { port, autoSelectFamilyAttemptTimeout, autoSelectFamily } = options;`
`1313`	`1313`
	`1314`	`+ validateString(host, 'options.host');`
	`1315`	`+`
`1314`	`1316`	`if (localAddress && !isIP(localAddress)) {`
`1315`	`1317`	`throw new ERR_INVALID_IP_ADDRESS(localAddress);`
`1316`	`1318`	`}`

Collapse file

`‎test/parallel/test-net-connect-options-invalid.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-net-connect-options-invalid.js

+12Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,3 +25,15 @@ const net = require('net');`
`25`	`25`	`});`
`26`	`26`	`});`
`27`	`27`	`}`
	`28`	`+`
	`29`	`+{`
	`30`	`+ assert.throws(() => {`
	`31`	`+ net.createConnection({`
	`32`	`+ host: ['192.168.0.1'],`
	`33`	`+ port: 8080,`
	`34`	`+ });`
	`35`	`+ }, {`
	`36`	`+ code: 'ERR_INVALID_ARG_TYPE',`
	`37`	`+ name: 'TypeError',`
	`38`	`+ });`
	`39`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.