GeezerVison is showing github.com — benchmark: use let/const instead of var in buffers · nodejs/node@47b5367
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-bytelength.js +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -16,8 +16,8 @@ const chars = [ | 16 | 16 | ]; | 17 | 17 |
| 18 | 18 | function main({ n, len, encoding }) { | 19 | | - var strings = []; | 20 | | - var results = [ len * 16 ]; | | 19 | + let strings = []; | | 20 | + let results = [ len * 16 ]; | 21 | 21 | if (encoding === 'buffer') { | 22 | 22 | strings = [ Buffer.alloc(len * 16, 'a') ]; | 23 | 23 | } else { | |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-compare-instance-method.js +5-6Lines changed: 5 additions & 6 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -12,47 +12,46 @@ function main({ n, size, args }) { | 12 | 12 | const b1 = Buffer.alloc(size, 'a'); | 13 | 13 | const b0Len = b0.length; | 14 | 14 | const b1Len = b1.length; | 15 | | - var i; | 16 | 15 |
| 17 | 16 | b1[size - 1] = 'b'.charCodeAt(0); | 18 | 17 |
| 19 | 18 | switch (args) { | 20 | 19 | case 2: | 21 | 20 | b0.compare(b1, 0); | 22 | 21 | bench.start(); | 23 | | - for (i = 0; i < n; i++) { | | 22 | + for (let i = 0; i < n; i++) { | 24 | 23 | b0.compare(b1, 0); | 25 | 24 | } | 26 | 25 | bench.end(n); | 27 | 26 | break; | 28 | 27 | case 3: | 29 | 28 | b0.compare(b1, 0, b1Len); | 30 | 29 | bench.start(); | 31 | | - for (i = 0; i < n; i++) { | | 30 | + for (let i = 0; i < n; i++) { | 32 | 31 | b0.compare(b1, 0, b1Len); | 33 | 32 | } | 34 | 33 | bench.end(n); | 35 | 34 | break; | 36 | 35 | case 4: | 37 | 36 | b0.compare(b1, 0, b1Len, 0); | 38 | 37 | bench.start(); | 39 | | - for (i = 0; i < n; i++) { | | 38 | + for (let i = 0; i < n; i++) { | 40 | 39 | b0.compare(b1, 0, b1Len, 0); | 41 | 40 | } | 42 | 41 | bench.end(n); | 43 | 42 | break; | 44 | 43 | case 5: | 45 | 44 | b0.compare(b1, 0, b1Len, 0, b0Len); | 46 | 45 | bench.start(); | 47 | | - for (i = 0; i < n; i++) { | | 46 | + for (let i = 0; i < n; i++) { | 48 | 47 | b0.compare(b1, 0, b1Len, 0, b0Len); | 49 | 48 | } | 50 | 49 | bench.end(n); | 51 | 50 | break; | 52 | 51 | default: | 53 | 52 | b0.compare(b1); | 54 | 53 | bench.start(); | 55 | | - for (i = 0; i < n; i++) { | | 54 | + for (let i = 0; i < n; i++) { | 56 | 55 | b0.compare(b1); | 57 | 56 | } | 58 | 57 | bench.end(n); | |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-hex.js +2-3Lines changed: 2 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -9,16 +9,15 @@ const bench = common.createBenchmark(main, { | 9 | 9 |
| 10 | 10 | function main({ len, n }) { | 11 | 11 | const buf = Buffer.alloc(len); | 12 | | - var i; | 13 | 12 |
| 14 | | - for (i = 0; i < buf.length; i++) | | 13 | + for (let i = 0; i < buf.length; i++) | 15 | 14 | buf[i] = i & 0xff; | 16 | 15 |
| 17 | 16 | const hex = buf.toString('hex'); | 18 | 17 |
| 19 | 18 | bench.start(); | 20 | 19 |
| 21 | | - for (i = 0; i < n; i += 1) | | 20 | + for (let i = 0; i < n; i += 1) | 22 | 21 | Buffer.from(hex, 'hex'); | 23 | 22 |
| 24 | 23 | bench.end(n); | |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-indexof.js +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -25,7 +25,7 @@ const bench = common.createBenchmark(main, { | 25 | 25 | }); | 26 | 26 |
| 27 | 27 | function main({ n, search, encoding, type }) { | 28 | | - var aliceBuffer = fs.readFileSync( | | 28 | + let aliceBuffer = fs.readFileSync( | 29 | 29 | path.resolve(__dirname, '../fixtures/alice.html') | 30 | 30 | ); | 31 | 31 |
| |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-iterate.js +4-4Lines changed: 4 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -29,23 +29,23 @@ function main({ size, type, method, n }) { | 29 | 29 | } | 30 | 30 |
| 31 | 31 | function benchFor(buffer, n) { | 32 | | - for (var k = 0; k < n; k++) { | 33 | | - for (var i = 0; i < buffer.length; i++) { | | 32 | + for (let k = 0; k < n; k++) { | | 33 | + for (let i = 0; i < buffer.length; i++) { | 34 | 34 | assert(buffer[i] === 0); | 35 | 35 | } | 36 | 36 | } | 37 | 37 | } | 38 | 38 |
| 39 | 39 | function benchForOf(buffer, n) { | 40 | | - for (var k = 0; k < n; k++) { | | 40 | + for (let k = 0; k < n; k++) { | 41 | 41 | for (const b of buffer) { | 42 | 42 | assert(b === 0); | 43 | 43 | } | 44 | 44 | } | 45 | 45 | } | 46 | 46 |
| 47 | 47 | function benchIterator(buffer, n) { | 48 | | - for (var k = 0; k < n; k++) { | | 48 | + for (let k = 0; k < n; k++) { | 49 | 49 | const iter = buffer[Symbol.iterator](); | 50 | 50 | let cur = iter.next(); | 51 | 51 |
| |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-swap.js +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -36,7 +36,7 @@ Buffer.prototype.htons = function htons() { | 36 | 36 | Buffer.prototype.htonl = function htonl() { | 37 | 37 | if (this.length % 4 !== 0) | 38 | 38 | throw new RangeError(); | 39 | | - for (var i = 0; i < this.length; i += 4) { | | 39 | + for (let i = 0; i < this.length; i += 4) { | 40 | 40 | swap(this, i, i + 3); | 41 | 41 | swap(this, i + 1, i + 2); | 42 | 42 | } | @@ -66,7 +66,7 @@ function createBuffer(len, aligned) { | 66 | 66 | function genMethod(method) { | 67 | 67 | const fnString = ` | 68 | 68 | return function ${method}(n, buf) { | 69 | | - for (var i = 0; i <= n; i++) | | 69 | + for (let i = 0; i <= n; i++) | 70 | 70 | buf.${method}(); | 71 | 71 | }`; | 72 | 72 | return (new Function(fnString))(); | |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-tostring.js +4-5Lines changed: 4 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -15,29 +15,28 @@ function main({ encoding, args, len, n }) { | 15 | 15 | if (encoding.length === 0) | 16 | 16 | encoding = undefined; | 17 | 17 |
| 18 | | - var i; | 19 | 18 | switch (args) { | 20 | 19 | case 1: | 21 | 20 | bench.start(); | 22 | | - for (i = 0; i < n; i += 1) | | 21 | + for (let i = 0; i < n; i += 1) | 23 | 22 | buf.toString(encoding); | 24 | 23 | bench.end(n); | 25 | 24 | break; | 26 | 25 | case 2: | 27 | 26 | bench.start(); | 28 | | - for (i = 0; i < n; i += 1) | | 27 | + for (let i = 0; i < n; i += 1) | 29 | 28 | buf.toString(encoding, 0); | 30 | 29 | bench.end(n); | 31 | 30 | break; | 32 | 31 | case 3: | 33 | 32 | bench.start(); | 34 | | - for (i = 0; i < n; i += 1) | | 33 | + for (let i = 0; i < n; i += 1) | 35 | 34 | buf.toString(encoding, 0, len); | 36 | 35 | bench.end(n); | 37 | 36 | break; | 38 | 37 | default: | 39 | 38 | bench.start(); | 40 | | - for (i = 0; i < n; i += 1) | | 39 | + for (let i = 0; i < n; i += 1) | 41 | 40 | buf.toString(); | 42 | 41 | bench.end(n); | 43 | 42 | break; | |
Collapse file Copy file name to clipboardExpand all lines: benchmark/buffers/buffer-write-string.js +6-8Lines changed: 6 additions & 8 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -15,21 +15,19 @@ function main({ len, n, encoding, args }) { | 15 | 15 | let start = 0; | 16 | 16 | const buf = Buffer.allocUnsafe(len); | 17 | 17 |
| 18 | | - var i; | 19 | | - | 20 | 18 | switch (args) { | 21 | 19 | case 'offset': | 22 | 20 | string = 'a'.repeat(Math.floor(len / 2)); | 23 | 21 | start = len - string.length; | 24 | 22 | if (encoding) { | 25 | 23 | bench.start(); | 26 | | - for (i = 0; i < n; ++i) { | | 24 | + for (let i = 0; i < n; ++i) { | 27 | 25 | buf.write(string, start, encoding); | 28 | 26 | } | 29 | 27 | bench.end(n); | 30 | 28 | } else { | 31 | 29 | bench.start(); | 32 | | - for (i = 0; i < n; ++i) { | | 30 | + for (let i = 0; i < n; ++i) { | 33 | 31 | buf.write(string, start); | 34 | 32 | } | 35 | 33 | bench.end(n); | @@ -39,13 +37,13 @@ function main({ len, n, encoding, args }) { | 39 | 37 | string = 'a'.repeat(len); | 40 | 38 | if (encoding) { | 41 | 39 | bench.start(); | 42 | | - for (i = 0; i < n; ++i) { | | 40 | + for (let i = 0; i < n; ++i) { | 43 | 41 | buf.write(string, 0, buf.length, encoding); | 44 | 42 | } | 45 | 43 | bench.end(n); | 46 | 44 | } else { | 47 | 45 | bench.start(); | 48 | | - for (i = 0; i < n; ++i) { | | 46 | + for (let i = 0; i < n; ++i) { | 49 | 47 | buf.write(string, 0, buf.length); | 50 | 48 | } | 51 | 49 | bench.end(n); | @@ -55,13 +53,13 @@ function main({ len, n, encoding, args }) { | 55 | 53 | string = 'a'.repeat(len); | 56 | 54 | if (encoding) { | 57 | 55 | bench.start(); | 58 | | - for (i = 0; i < n; ++i) { | | 56 | + for (let i = 0; i < n; ++i) { | 59 | 57 | buf.write(string, encoding); | 60 | 58 | } | 61 | 59 | bench.end(n); | 62 | 60 | } else { | 63 | 61 | bench.start(); | 64 | | - for (i = 0; i < n; ++i) { | | 62 | + for (let i = 0; i < n; ++i) { | 65 | 63 | buf.write(string); | 66 | 64 | } | 67 | 65 | bench.end(n); | |
|