GeezerVison is showing github.com — test: fix status when compiled without inspector · nodejs/node@4b23ac8
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: test/common/index.js +3-1Lines changed: 3 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -54,6 +54,7 @@ const noop = () => {}; | 54 | 54 | const hasCrypto = Boolean(process.versions.openssl) && | 55 | 55 | !process.env.NODE_SKIP_CRYPTO; | 56 | 56 |
| | 57 | +const hasInspector = Boolean(process.features.inspector); | 57 | 58 | const hasSQLite = Boolean(process.versions.sqlite); | 58 | 59 |
| 59 | 60 | const hasQuic = hasCrypto && !!process.features.quic; | @@ -711,7 +712,7 @@ function expectsError(validator, exact) { | 711 | 712 | } | 712 | 713 |
| 713 | 714 | function skipIfInspectorDisabled() { | 714 | | - if (!process.features.inspector) { | | 715 | + if (!hasInspector) { | 715 | 716 | skip('V8 inspector is disabled'); | 716 | 717 | } | 717 | 718 | } | @@ -930,6 +931,7 @@ const common = { | 930 | 931 | hasIntl, | 931 | 932 | hasCrypto, | 932 | 933 | hasQuic, | | 934 | + hasInspector, | 933 | 935 | hasSQLite, | 934 | 936 | invalidArgTypeHelper, | 935 | 937 | isAlive, | |
Collapse file Copy file name to clipboardExpand all lines: test/common/index.mjs +2Lines changed: 2 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -17,6 +17,7 @@ const { | 17 | 17 | getTTYfd, | 18 | 18 | hasCrypto, | 19 | 19 | hasQuic, | | 20 | + hasInspector, | 20 | 21 | hasSQLite, | 21 | 22 | hasIntl, | 22 | 23 | hasIPv6, | @@ -68,6 +69,7 @@ export { | 68 | 69 | getTTYfd, | 69 | 70 | hasCrypto, | 70 | 71 | hasQuic, | | 72 | + hasInspector, | 71 | 73 | hasSQLite, | 72 | 74 | hasIntl, | 73 | 75 | hasIPv6, | |
Collapse file Copy file name to clipboardExpand all lines: test/common/wpt.js +6Lines changed: 6 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -412,6 +412,9 @@ class BuildRequirement { | 412 | 412 | // Not using common.hasCrypto because of the global leak checks | 413 | 413 | this.hasCrypto = Boolean(process.versions.openssl) && | 414 | 414 | !process.env.NODE_SKIP_CRYPTO; | | 415 | + | | 416 | + // Not using common.hasInspector because of the global leak checks | | 417 | + this.hasInspector = Boolean(process.features.inspector); | 415 | 418 | } | 416 | 419 |
| 417 | 420 | /** | @@ -429,6 +432,9 @@ class BuildRequirement { | 429 | 432 | if (requires.has('crypto') && !this.hasCrypto) { | 430 | 433 | return 'crypto'; | 431 | 434 | } | | 435 | + if (requires.has('inspector') && !this.hasInspector) { | | 436 | + return 'inspector'; | | 437 | + } | 432 | 438 | return false; | 433 | 439 | } | 434 | 440 | } | |
Collapse file Copy file name to clipboardExpand all lines: test/parallel/test-process-get-builtin.mjs +5-1Lines changed: 5 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
| 1 | | -import { hasCrypto, hasIntl, hasSQLite } from '../common/index.mjs'; | | 1 | +import { hasCrypto, hasIntl, hasInspector, hasSQLite } from '../common/index.mjs'; | 2 | 2 | import assert from 'node:assert'; | 3 | 3 | import { builtinModules } from 'node:module'; | 4 | 4 | import { isMainThread } from 'node:worker_threads'; | @@ -39,6 +39,10 @@ if (!hasIntl) { | 39 | 39 | // TODO(@jasnell): Remove this once node:quic graduates from unflagged. | 40 | 40 | publicBuiltins.delete('node:quic'); | 41 | 41 |
| | 42 | +if (!hasInspector) { | | 43 | + publicBuiltins.delete('inspector'); | | 44 | + publicBuiltins.delete('inspector/promises'); | | 45 | +} | 42 | 46 | if (!hasSQLite) { | 43 | 47 | publicBuiltins.delete('node:sqlite'); | 44 | 48 | } | |
Collapse file Copy file name to clipboardExpand all lines: test/wpt/status/console.json +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
| 1 | 1 | { | 2 | 2 | "idlharness.any.js": { | 3 | 3 | "note": "https://github.com/nodejs/node/issues/44185", | 4 | | - "requires": ["crypto", "small-icu"] | | 4 | + "requires": ["crypto", "inspector", "small-icu"] | 5 | 5 | }, | 6 | 6 | "idlharness-shadowrealm.window.js": { | 7 | 7 | "skip": "ShadowRealm support is not enabled" | |
|