GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "url: make the context non-enumerable" · nodejs/node@4e111ce

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal
- url.js
test/parallel
- test-whatwg-url-custom-no-enumerable-context.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/url.js‎`

Copy file name to clipboardExpand all lines: lib/internal/url.js

+2-13Lines changed: 2 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -246,14 +246,7 @@ function onParseError(flags, input) {`
`246`	`246`	`// Reused by URL constructor and URL#href setter.`
`247`	`247`	`function parse(url, input, base) {`
`248`	`248`	`const base_context = base ? base[context] : undefined;`
`249`		`- // In the URL#href setter`
`250`		`- if (!url[context]) {`
`251`		`- Object.defineProperty(url, context, {`
`252`		`- enumerable: false,`
`253`		`- configurable: false,`
`254`		`- value: new URLContext()`
`255`		`- });`
`256`		`- }`
	`249`	`+ url[context] = new URLContext();`
`257`	`250`	`_parse(input.trim(), -1, base_context, undefined,`
`258`	`251`	`onParseComplete.bind(url), onParseError);`
`259`	`252`	`}`
`@@ -1381,11 +1374,7 @@ function toPathIfFileURL(fileURLOrPath) {`
`1381`	`1374`	`}`
`1382`	`1375`
`1383`	`1376`	`function NativeURL(ctx) {`
`1384`		`- Object.defineProperty(this, context, {`
`1385`		`- enumerable: false,`
`1386`		`- configurable: false,`
`1387`		`- value: ctx`
`1388`		`- });`
	`1377`	`+ this[context] = ctx;`
`1389`	`1378`	`}`
`1390`	`1379`	`NativeURL.prototype = URL.prototype;`
`1391`	`1380`

Collapse file

`‎test/parallel/test-whatwg-url-custom-no-enumerable-context.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-url-custom-no-enumerable-context.js

-14Lines changed: 0 additions & 14 deletions

This file was deleted.

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.