GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — zlib: deprecate classes usage without `new` · nodejs/node@4ee87b8

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/api
- deprecations.md
lib
- zlib.js
test/parallel
- test-zlib.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/api/deprecations.md‎`

Copy file name to clipboardExpand all lines: doc/api/deprecations.md

+4-1Lines changed: 4 additions & 1 deletion

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -3737,14 +3737,17 @@ and [`crypto.setEngine()`][] all depend on this functionality from OpenSSL.
`3737`	`3737`
`3738`	`3738`	`<!-- YAML`
`3739`	`3739`	`changes:`
	`3740`	`+ - version: REPLACEME`
	`3741`	`+ pr-url: https://github.com/nodejs/node/pull/55718`
	`3742`	`+ description: Runtime deprecation.`
`3740`	`3743`	`- version:`
`3741`	`3744`	`- v22.9.0`
`3742`	`3745`	`- v20.18.0`
`3743`	`3746`	`pr-url: https://github.com/nodejs/node/pull/54708`
`3744`	`3747`	`description: Documentation-only deprecation.`
`3745`	`3748`	`-->`
`3746`	`3749`
`3747`		`-Type: Documentation-only`
	`3750`	`+Type: Runtime`
`3748`	`3751`
`3749`	`3752`	Instantiating classes without the `new` qualifier exported by the `node:zlib` module is deprecated.
`3750`	`3753`	It is recommended to use the `new` qualifier instead. This applies to all Zlib classes, such as `Deflate`,

Collapse file

`‎lib/zlib.js‎`

Copy file name to clipboardExpand all lines: lib/zlib.js

+30-18Lines changed: 30 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,9 @@ const {`
`46`	`46`	`genericNodeError,`
`47`	`47`	`} = require('internal/errors');`
`48`	`48`	`const { Transform, finished } = require('stream');`
	`49`	`+const {`
	`50`	`+ deprecateInstantiation,`
	`51`	`+} = require('internal/util');`
`49`	`52`	`const {`
`50`	`53`	`isArrayBufferView,`
`51`	`54`	`isAnyArrayBuffer,`
`@@ -686,57 +689,64 @@ Zlib.prototype.params = function params(level, strategy, callback) {`
`686`	`689`	`// generic zlib`
`687`	`690`	`// minimal 2-byte header`
`688`	`691`	`function Deflate(opts) {`
`689`		`- if (!(this instanceof Deflate))`
`690`		`- return new Deflate(opts);`
	`692`	`+ if (!(this instanceof Deflate)) {`
	`693`	`+ return deprecateInstantiation(Deflate, 'DEP0184', opts);`
	`694`	`+ }`
`691`	`695`	`ReflectApply(Zlib, this, [opts, DEFLATE]);`
`692`	`696`	`}`
`693`	`697`	`ObjectSetPrototypeOf(Deflate.prototype, Zlib.prototype);`
`694`	`698`	`ObjectSetPrototypeOf(Deflate, Zlib);`
`695`	`699`
`696`	`700`	`function Inflate(opts) {`
`697`		`- if (!(this instanceof Inflate))`
`698`		`- return new Inflate(opts);`
	`701`	`+ if (!(this instanceof Inflate)) {`
	`702`	`+ return deprecateInstantiation(Inflate, 'DEP0184', opts);`
	`703`	`+ }`
`699`	`704`	`ReflectApply(Zlib, this, [opts, INFLATE]);`
`700`	`705`	`}`
`701`	`706`	`ObjectSetPrototypeOf(Inflate.prototype, Zlib.prototype);`
`702`	`707`	`ObjectSetPrototypeOf(Inflate, Zlib);`
`703`	`708`
`704`	`709`	`function Gzip(opts) {`
`705`		`- if (!(this instanceof Gzip))`
`706`		`- return new Gzip(opts);`
	`710`	`+ if (!(this instanceof Gzip)) {`
	`711`	`+ return deprecateInstantiation(Gzip, 'DEP0184', opts);`
	`712`	`+ }`
`707`	`713`	`ReflectApply(Zlib, this, [opts, GZIP]);`
`708`	`714`	`}`
`709`	`715`	`ObjectSetPrototypeOf(Gzip.prototype, Zlib.prototype);`
`710`	`716`	`ObjectSetPrototypeOf(Gzip, Zlib);`
`711`	`717`
`712`	`718`	`function Gunzip(opts) {`
`713`		`- if (!(this instanceof Gunzip))`
`714`		`- return new Gunzip(opts);`
	`719`	`+ if (!(this instanceof Gunzip)) {`
	`720`	`+ return deprecateInstantiation(Gunzip, 'DEP0184', opts);`
	`721`	`+ }`
`715`	`722`	`ReflectApply(Zlib, this, [opts, GUNZIP]);`
`716`	`723`	`}`
`717`	`724`	`ObjectSetPrototypeOf(Gunzip.prototype, Zlib.prototype);`
`718`	`725`	`ObjectSetPrototypeOf(Gunzip, Zlib);`
`719`	`726`
`720`	`727`	`function DeflateRaw(opts) {`
`721`	`728`	`if (opts && opts.windowBits === 8) opts.windowBits = 9;`
`722`		`- if (!(this instanceof DeflateRaw))`
`723`		`- return new DeflateRaw(opts);`
	`729`	`+ if (!(this instanceof DeflateRaw)) {`
	`730`	`+ return deprecateInstantiation(DeflateRaw, 'DEP0184', opts);`
	`731`	`+ }`
`724`	`732`	`ReflectApply(Zlib, this, [opts, DEFLATERAW]);`
`725`	`733`	`}`
`726`	`734`	`ObjectSetPrototypeOf(DeflateRaw.prototype, Zlib.prototype);`
`727`	`735`	`ObjectSetPrototypeOf(DeflateRaw, Zlib);`
`728`	`736`
`729`	`737`	`function InflateRaw(opts) {`
`730`		`- if (!(this instanceof InflateRaw))`
`731`		`- return new InflateRaw(opts);`
	`738`	`+ if (!(this instanceof InflateRaw)) {`
	`739`	`+ return deprecateInstantiation(InflateRaw, 'DEP0184', opts);`
	`740`	`+ }`
`732`	`741`	`ReflectApply(Zlib, this, [opts, INFLATERAW]);`
`733`	`742`	`}`
`734`	`743`	`ObjectSetPrototypeOf(InflateRaw.prototype, Zlib.prototype);`
`735`	`744`	`ObjectSetPrototypeOf(InflateRaw, Zlib);`
`736`	`745`
`737`	`746`	`function Unzip(opts) {`
`738`		`- if (!(this instanceof Unzip))`
`739`		`- return new Unzip(opts);`
	`747`	`+ if (!(this instanceof Unzip)) {`
	`748`	`+ return deprecateInstantiation(Unzip, 'DEP0184', opts);`
	`749`	`+ }`
`740`	`750`	`ReflectApply(Zlib, this, [opts, UNZIP]);`
`741`	`751`	`}`
`742`	`752`	`ObjectSetPrototypeOf(Unzip.prototype, Zlib.prototype);`
`@@ -801,16 +811,18 @@ ObjectSetPrototypeOf(Brotli.prototype, Zlib.prototype);`
`801`	`811`	`ObjectSetPrototypeOf(Brotli, Zlib);`
`802`	`812`
`803`	`813`	`function BrotliCompress(opts) {`
`804`		`- if (!(this instanceof BrotliCompress))`
`805`		`- return new BrotliCompress(opts);`
	`814`	`+ if (!(this instanceof BrotliCompress)) {`
	`815`	`+ return deprecateInstantiation(BrotliCompress, 'DEP0184', opts);`
	`816`	`+ }`
`806`	`817`	`ReflectApply(Brotli, this, [opts, BROTLI_ENCODE]);`
`807`	`818`	`}`
`808`	`819`	`ObjectSetPrototypeOf(BrotliCompress.prototype, Brotli.prototype);`
`809`	`820`	`ObjectSetPrototypeOf(BrotliCompress, Brotli);`
`810`	`821`
`811`	`822`	`function BrotliDecompress(opts) {`
`812`		`- if (!(this instanceof BrotliDecompress))`
`813`		`- return new BrotliDecompress(opts);`
	`823`	`+ if (!(this instanceof BrotliDecompress)) {`
	`824`	`+ return deprecateInstantiation(BrotliDecompress, 'DEP0184', opts);`
	`825`	`+ }`
`814`	`826`	`ReflectApply(Brotli, this, [opts, BROTLI_DECODE]);`
`815`	`827`	`}`
`816`	`828`	`ObjectSetPrototypeOf(BrotliDecompress.prototype, Brotli.prototype);`

Collapse file

`‎test/parallel/test-zlib.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-zlib.js

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Flags: --no-warnings`
`1`	`2`	`// Copyright Joyent, Inc. and other Node contributors.`
`2`	`3`	`//`
`3`	`4`	`// Permission is hereby granted, free of charge, to any person obtaining a`
`@@ -230,3 +231,10 @@ testKeys.forEach(common.mustCall((file) => {`
`230`	`231`	`}, trickle.length));`
`231`	`232`	`}, chunkSize.length));`
`232`	`233`	`}, testKeys.length));`
	`234`	`+`
	`235`	`+{`
	`236`	`+ // Test instantiation without 'new'`
	`237`	+ common.expectWarning('DeprecationWarning', `Instantiating Gzip without the 'new' keyword has been deprecated.`, 'DEP0184');
	`238`	`+ const gzip = zlib.Gzip();`
	`239`	`+ assert.ok(gzip instanceof zlib.Gzip);`
	`240`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.