GeezerVison is showing github.com — deps: V8: cherry-pick f915fa4c9f41 · nodejs/node@52d3944
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: common.gypi +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
37 | 37 |
|
38 | 38 | # Reset this number to 0 on major V8 upgrades. |
39 | 39 | # Increment by one for each non-official patch applied to deps/v8. |
40 | | - 'v8_embedder_string': '-node.9', |
| 40 | + 'v8_embedder_string': '-node.10', |
41 | 41 |
|
42 | 42 | ##### V8 defaults for Node.js ##### |
43 | 43 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: deps/v8/src/codegen/compiler.cc +8-1Lines changed: 8 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -1338,7 +1338,14 @@ MaybeHandle<Code> GetOrCompileOptimized( |
1338 | 1338 | } |
1339 | 1339 |
|
1340 | 1340 | // Do not optimize when debugger needs to hook into every call. |
1341 | | - if (isolate->debug()->needs_check_on_function_call()) return {}; |
| 1341 | + if (isolate->debug()->needs_check_on_function_call()) { |
| 1342 | + // Reset the OSR urgency to avoid triggering this compilation request on |
| 1343 | + // every iteration and thereby skipping other interrupts. |
| 1344 | + if (IsOSR(osr_offset)) { |
| 1345 | + function->feedback_vector()->reset_osr_urgency(); |
| 1346 | + } |
| 1347 | + return {}; |
| 1348 | + } |
1342 | 1349 |
|
1343 | 1350 | // Do not optimize if we need to be able to set break points. |
1344 | 1351 | if (shared->HasBreakInfo(isolate)) return {}; |
|
Collapse file
Copy file name to clipboard +15Lines changed: 15 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
| 1 | +// Copyright 2024 the V8 project authors. All rights reserved. |
| 2 | +// Use of this source code is governed by a BSD-style license that can be |
| 3 | +// found in the LICENSE file. |
| 4 | + |
| 5 | +// Flags: --enable-inspector |
| 6 | + |
| 7 | +var Debug = debug.Debug; |
| 8 | +Debug.sendMessageForMethodChecked('Runtime.enable', {}); |
| 9 | +const {msgid, msg} = Debug.createMessage('Runtime.evaluate', { |
| 10 | + expression: 'while(true) {}', |
| 11 | + throwOnSideEffect: true, |
| 12 | + timeout: 1000, |
| 13 | +}) |
| 14 | +Debug.sendMessage(msg); |
| 15 | +Debug.takeReplyChecked(msgid).toString(); |