GeezerVison is showing github.com — test: remove OpenSSL 1.0.2 error message compat · nodejs/node@533170d
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-tls-junk-server.js +1-3Lines changed: 1 addition & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -21,9 +21,7 @@ server.listen(0, function() { |
21 | 21 | req.end(); |
22 | 22 |
|
23 | 23 | req.once('error', common.mustCall(function(err) { |
24 | | - // OpenSSL 1.0.x and 1.1.x use different error messages for junk inputs. |
25 | | - assert(/unknown protocol/.test(err.message) || |
26 | | - /wrong version number/.test(err.message)); |
| 24 | + assert(/wrong version number/.test(err.message)); |
27 | 25 | server.close(); |
28 | 26 | })); |
29 | 27 | }); |
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-tls-no-sslv3.js +1-3Lines changed: 1 addition & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -42,8 +42,6 @@ process.on('exit', function() { |
42 | 42 | common.printSkipMessage('`openssl s_client -ssl3` not supported.'); |
43 | 43 | } else { |
44 | 44 | assert.strictEqual(errors.length, 1); |
45 | | - // OpenSSL 1.0.x and 1.1.x report invalid client versions differently. |
46 | | - assert(/:wrong version number/.test(errors[0].message) || |
47 | | - /:version too low/.test(errors[0].message)); |
| 45 | + assert(/:version too low/.test(errors[0].message)); |
48 | 46 | } |
49 | 47 | }); |
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-tls-server-failed-handshake-emits-clienterror.js +1-2Lines changed: 1 addition & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -20,9 +20,8 @@ const server = tls.createServer({}) |
20 | 20 | }).on('tlsClientError', common.mustCall(function(e) { |
21 | 21 | assert.ok(e instanceof Error, |
22 | 22 | 'Instance of Error should be passed to error handler'); |
23 | | - // OpenSSL 1.0.x and 1.1.x use different error codes for junk inputs. |
24 | 23 | assert.ok( |
25 | | - /SSL routines:[^:]*:(unknown protocol|wrong version number)/.test( |
| 24 | + /SSL routines:[^:]*:wrong version number/.test( |
26 | 25 | e.message), |
27 | 26 | 'Expecting SSL unknown protocol'); |
28 | 27 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-tls-socket-failed-handshake-emits-error.js +1-2Lines changed: 1 addition & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -20,9 +20,8 @@ const server = net.createServer(function(c) { |
20 | 20 | s.on('error', common.mustCall(function(e) { |
21 | 21 | assert.ok(e instanceof Error, |
22 | 22 | 'Instance of Error should be passed to error handler'); |
23 | | - // OpenSSL 1.0.x and 1.1.x use different error codes for junk inputs. |
24 | 23 | assert.ok( |
25 | | - /SSL routines:[^:]*:(unknown protocol|wrong version number)/.test( |
| 24 | + /SSL routines:[^:]*:wrong version number/.test( |
26 | 25 | e.message), |
27 | 26 | 'Expecting SSL unknown protocol'); |
28 | 27 | })); |
|