GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: move READONLY_* macros into util.h · nodejs/node@53b59b4

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node.cc‎`

Copy file name to clipboardExpand all lines: src/node.cc

+3-28Lines changed: 3 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,6 @@ using v8::Array;`
`124`	`124`	`using v8::Boolean;`
`125`	`125`	`using v8::Context;`
`126`	`126`	`using v8::DEFAULT;`
`127`		`-using v8::DontEnum;`
`128`	`127`	`using v8::EscapableHandleScope;`
`129`	`128`	`using v8::Exception;`
`130`	`129`	`using v8::Function;`
`@@ -147,8 +146,6 @@ using v8::Nothing;`
`147`	`146`	`using v8::Null;`
`148`	`147`	`using v8::Object;`
`149`	`148`	`using v8::ObjectTemplate;`
`150`		`-using v8::PropertyAttribute;`
`151`		`-using v8::ReadOnly;`
`152`	`149`	`using v8::Script;`
`153`	`150`	`using v8::ScriptOrigin;`
`154`	`151`	`using v8::SealHandleScope;`
`@@ -954,31 +951,12 @@ static Local<Object> GetFeatures(Environment* env) {`
`954`	`951`	`static void DebugProcess(const FunctionCallbackInfo<Value>& args);`
`955`	`952`	`static void DebugEnd(const FunctionCallbackInfo<Value>& args);`
`956`	`953`
`957`		`-namespace {`
`958`		`-`
`959`		`-#define READONLY_PROPERTY(obj, str, var) \`
`960`		`- do { \`
`961`		`- obj->DefineOwnProperty(env->context(), \`
`962`		`- OneByteString(env->isolate(), str), \`
`963`		`- var, \`
`964`		`- ReadOnly).FromJust(); \`
`965`		`- } while (0)`
`966`		`-`
`967`		`-#define READONLY_DONT_ENUM_PROPERTY(obj, str, var) \`
`968`		`- do { \`
`969`		`- obj->DefineOwnProperty(env->context(), \`
`970`		`- OneByteString(env->isolate(), str), \`
`971`		`- var, \`
`972`		`- static_cast<PropertyAttribute>(ReadOnly\|DontEnum)) \`
`973`		`- .FromJust(); \`
`974`		`- } while (0)`
`975`		`-`
`976`		`-} // anonymous namespace`
`977`		`-`
`978`	`954`	`void SetupProcessObject(Environment* env,`
`979`	`955`	`const std::vector<std::string>& args,`
`980`	`956`	`const std::vector<std::string>& exec_args) {`
`981`		`- HandleScope scope(env->isolate());`
	`957`	`+ Isolate* isolate = env->isolate();`
	`958`	`+ HandleScope scope(isolate);`
	`959`	`+ Local<Context> context = env->context();`
`982`	`960`
`983`	`961`	`Local<Object> process = env->process_object();`
`984`	`962`
`@@ -1319,9 +1297,6 @@ void SetupProcessObject(Environment* env,`
`1319`	`1297`	`}`
`1320`	`1298`
`1321`	`1299`
`1322`		`-#undef READONLY_PROPERTY`
`1323`		`-`
`1324`		`-`
`1325`	`1300`	`void SignalExit(int signo) {`
`1326`	`1301`	`uv_tty_reset_mode();`
`1327`	`1302`	`#ifdef __FreeBSD__`

Collapse file

`‎src/node_config.cc‎`

Copy file name to clipboardExpand all lines: src/node_config.cc

+15-43Lines changed: 15 additions & 43 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,68 +12,40 @@ using v8::Isolate;`
`12`	`12`	`using v8::Local;`
`13`	`13`	`using v8::Number;`
`14`	`14`	`using v8::Object;`
`15`		`-using v8::ReadOnly;`
`16`		`-using v8::String;`
`17`	`15`	`using v8::Value;`
`18`	`16`
`19`	`17`	`// The config binding is used to provide an internal view of compile or runtime`
`20`	`18`	`// config options that are required internally by lib/*.js code. This is an`
`21`	`19`	`// alternative to dropping additional properties onto the process object as`
`22`	`20`	`// has been the practice previously in node.cc.`
`23`	`21`
`24`		`-#define READONLY_BOOLEAN_PROPERTY(str) \`
`25`		`- do { \`
`26`		`- target->DefineOwnProperty(context, \`
`27`		`- FIXED_ONE_BYTE_STRING(isolate, str), \`
`28`		`- True(isolate), ReadOnly).FromJust(); \`
`29`		`- } while (0)`
`30`		`-`
`31`		`-#define READONLY_STRING_PROPERTY(obj, str, val) \`
`32`		`- do { \`
`33`		`- (obj)->DefineOwnProperty(context, \`
`34`		`- FIXED_ONE_BYTE_STRING(isolate, str), \`
`35`		`- String::NewFromUtf8( \`
`36`		`- isolate, \`
`37`		`- val.data(), \`
`38`		`- v8::NewStringType::kNormal).ToLocalChecked(), \`
`39`		`- ReadOnly).FromJust(); \`
`40`		`- } while (0)`
`41`		`-`
`42`		`-`
`43`		`-#define READONLY_PROPERTY(obj, name, value) \`
`44`		`- do { \`
`45`		`- obj->DefineOwnProperty(env->context(), \`
`46`		`- FIXED_ONE_BYTE_STRING(isolate, name), \`
`47`		`- value, ReadOnly).FromJust(); \`
`48`		`- } while (0)`
`49`		`-`
`50`	`22`	`static void Initialize(Local<Object> target,`
`51`	`23`	`Local<Value> unused,`
`52`	`24`	`Local<Context> context) {`
`53`	`25`	`Environment* env = Environment::GetCurrent(context);`
`54`	`26`	`Isolate* isolate = env->isolate();`
`55`	`27`
`56`	`28`	`#ifdef NODE_FIPS_MODE`
`57`		`- READONLY_BOOLEAN_PROPERTY("fipsMode");`
	`29`	`+ READONLY_TRUE_PROPERTY(target, "fipsMode");`
`58`	`30`	`// TODO(addaleax): Use options parser variable instead.`
`59`	`31`	`if (per_process_opts->force_fips_crypto)`
`60`		`- READONLY_BOOLEAN_PROPERTY("fipsForced");`
	`32`	`+ READONLY_TRUE_PROPERTY(target, "fipsForced");`
`61`	`33`	`#endif`
`62`	`34`
`63`	`35`	`#ifdef NODE_HAVE_I18N_SUPPORT`
`64`	`36`
`65`		`- READONLY_BOOLEAN_PROPERTY("hasIntl");`
	`37`	`+ READONLY_TRUE_PROPERTY(target, "hasIntl");`
`66`	`38`
`67`	`39`	`#ifdef NODE_HAVE_SMALL_ICU`
`68`		`- READONLY_BOOLEAN_PROPERTY("hasSmallICU");`
	`40`	`+ READONLY_TRUE_PROPERTY(target, "hasSmallICU");`
`69`	`41`	`#endif // NODE_HAVE_SMALL_ICU`
`70`	`42`
`71`	`43`	`#if NODE_USE_V8_PLATFORM`
`72`		`- READONLY_BOOLEAN_PROPERTY("hasTracing");`
	`44`	`+ READONLY_TRUE_PROPERTY(target, "hasTracing");`
`73`	`45`	`#endif`
`74`	`46`
`75`	`47`	`#if !defined(NODE_WITHOUT_NODE_OPTIONS)`
`76`		`- READONLY_BOOLEAN_PROPERTY("hasNodeOptions");`
	`48`	`+ READONLY_TRUE_PROPERTY(target, "hasNodeOptions");`
`77`	`49`	`#endif`
`78`	`50`
`79`	`51`	`// TODO(addaleax): This seems to be an unused, private API. Remove it?`
`@@ -83,35 +55,35 @@ static void Initialize(Local<Object> target,`
`83`	`55`	`#endif // NODE_HAVE_I18N_SUPPORT`
`84`	`56`
`85`	`57`	`if (env->options()->preserve_symlinks)`
`86`		`- READONLY_BOOLEAN_PROPERTY("preserveSymlinks");`
	`58`	`+ READONLY_TRUE_PROPERTY(target, "preserveSymlinks");`
`87`	`59`	`if (env->options()->preserve_symlinks_main)`
`88`		`- READONLY_BOOLEAN_PROPERTY("preserveSymlinksMain");`
	`60`	`+ READONLY_TRUE_PROPERTY(target, "preserveSymlinksMain");`
`89`	`61`
`90`	`62`	`if (env->options()->experimental_modules) {`
`91`		`- READONLY_BOOLEAN_PROPERTY("experimentalModules");`
	`63`	`+ READONLY_TRUE_PROPERTY(target, "experimentalModules");`
`92`	`64`	`const std::string& userland_loader = env->options()->userland_loader;`
`93`	`65`	`if (!userland_loader.empty()) {`
`94`	`66`	`READONLY_STRING_PROPERTY(target, "userLoader", userland_loader);`
`95`	`67`	`}`
`96`	`68`	`}`
`97`	`69`
`98`	`70`	`if (env->options()->experimental_vm_modules)`
`99`		`- READONLY_BOOLEAN_PROPERTY("experimentalVMModules");`
	`71`	`+ READONLY_TRUE_PROPERTY(target, "experimentalVMModules");`
`100`	`72`
`101`	`73`	`if (env->options()->experimental_worker)`
`102`		`- READONLY_BOOLEAN_PROPERTY("experimentalWorker");`
	`74`	`+ READONLY_TRUE_PROPERTY(target, "experimentalWorker");`
`103`	`75`
`104`	`76`	`if (env->options()->experimental_repl_await)`
`105`		`- READONLY_BOOLEAN_PROPERTY("experimentalREPLAwait");`
	`77`	`+ READONLY_TRUE_PROPERTY(target, "experimentalREPLAwait");`
`106`	`78`
`107`	`79`	`if (env->options()->pending_deprecation)`
`108`		`- READONLY_BOOLEAN_PROPERTY("pendingDeprecation");`
	`80`	`+ READONLY_TRUE_PROPERTY(target, "pendingDeprecation");`
`109`	`81`
`110`	`82`	`if (env->options()->expose_internals)`
`111`		`- READONLY_BOOLEAN_PROPERTY("exposeInternals");`
	`83`	`+ READONLY_TRUE_PROPERTY(target, "exposeInternals");`
`112`	`84`
`113`	`85`	`if (env->abort_on_uncaught_exception())`
`114`		`- READONLY_BOOLEAN_PROPERTY("shouldAbortOnUncaughtException");`
	`86`	`+ READONLY_TRUE_PROPERTY(target, "shouldAbortOnUncaughtException");`
`115`	`87`
`116`	`88`	`READONLY_PROPERTY(target,`
`117`	`89`	`"bits",`

Collapse file

`‎src/util.h‎`

Copy file name to clipboardExpand all lines: src/util.h

+25Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -479,6 +479,31 @@ template <typename T, typename U>`
`479`	`479`	`inline v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,`
`480`	`480`	`const std::unordered_map<T, U>& map);`
`481`	`481`
	`482`	+// These macros expects a `Isolate* isolate` and a `Local<Context> context`
	`483`	`+// to be in the scope.`
	`484`	`+#define READONLY_PROPERTY(obj, name, value) \`
	`485`	`+ do { \`
	`486`	`+ obj->DefineOwnProperty( \`
	`487`	`+ context, FIXED_ONE_BYTE_STRING(isolate, name), value, v8::ReadOnly) \`
	`488`	`+ .FromJust(); \`
	`489`	`+ } while (0)`
	`490`	`+`
	`491`	`+#define READONLY_DONT_ENUM_PROPERTY(obj, name, var) \`
	`492`	`+ do { \`
	`493`	`+ obj->DefineOwnProperty( \`
	`494`	`+ context, \`
	`495`	`+ OneByteString(isolate, name), \`
	`496`	`+ var, \`
	`497`	`+ static_cast<v8::PropertyAttribute>(v8::ReadOnly \| v8::DontEnum)) \`
	`498`	`+ .FromJust(); \`
	`499`	`+ } while (0)`
	`500`	`+`
	`501`	`+#define READONLY_TRUE_PROPERTY(obj, name) \`
	`502`	`+ READONLY_PROPERTY(obj, name, True(isolate))`
	`503`	`+`
	`504`	`+#define READONLY_STRING_PROPERTY(obj, name, str) \`
	`505`	`+ READONLY_PROPERTY(obj, name, ToV8Value(context, str).ToLocalChecked())`
	`506`	`+`
`482`	`507`	`} // namespace node`
`483`	`508`
`484`	`509`	`#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.