GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove common.PORT from parallel tests · nodejs/node@53b702f

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test
    • async-hooks
      • test-graph.tcp.js
      • test-graph.tls-write.js
      • test-tcpwrap.js
      • test-writewrap.js
    • parallel
      • test-net-connect-immediate-finish.js
    • sequential
      • test-tls-connect.js
      • test-tls-lookup.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/async-hooks/test-graph.tcp.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-graph.tcp.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const server = net
1515
.createServer(common.mustCall(onconnection))
1616
.on('listening', common.mustCall(onlistening));
1717

18-
server.listen(common.PORT);
18+
server.listen(0);
1919

2020
net.connect({ port: server.address().port, host: '::1' },
2121
common.mustCall(onconnected));
Collapse file

‎test/async-hooks/test-graph.tls-write.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-graph.tls-write.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ const server = tls
2525
})
2626
.on('listening', common.mustCall(onlistening))
2727
.on('secureConnection', common.mustCall(onsecureConnection))
28-
.listen(common.PORT);
28+
.listen(0);
2929

3030
function onlistening() {
3131
//
3232
// Creating client and connecting it to server
3333
//
3434
tls
35-
.connect(common.PORT, { rejectUnauthorized: false })
35+
.connect(server.address().port, { rejectUnauthorized: false })
3636
.on('secureConnect', common.mustCall(onsecureConnect));
3737
}
3838

Collapse file

‎test/async-hooks/test-tcpwrap.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-tcpwrap.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const server = net
2424

2525
// Calling server.listen creates a TCPWRAP synchronously
2626
{
27-
server.listen(common.PORT);
27+
server.listen(0);
2828
const tcpsservers = hooks.activitiesOfTypes('TCPSERVERWRAP');
2929
const tcpconnects = hooks.activitiesOfTypes('TCPCONNECTWRAP');
3030
assert.strictEqual(tcpsservers.length, 1);
Collapse file

‎test/async-hooks/test-writewrap.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-writewrap.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const server = tls
2323
})
2424
.on('listening', common.mustCall(onlistening))
2525
.on('secureConnection', common.mustCall(onsecureConnection))
26-
.listen(common.PORT);
26+
.listen(0);
2727

2828
assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length, 0);
2929

@@ -33,7 +33,7 @@ function onlistening() {
3333
// Creating client and connecting it to server
3434
//
3535
tls
36-
.connect(common.PORT, { rejectUnauthorized: false })
36+
.connect(server.address().port, { rejectUnauthorized: false })
3737
.on('secureConnect', common.mustCall(onsecureConnect));
3838

3939
assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length, 0);
Collapse file

‎test/parallel/test-net-connect-immediate-finish.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-connect-immediate-finish.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ const {
3838

3939
const client = net.connect({
4040
host: addresses.INVALID_HOST,
41-
port: common.PORT,
41+
port: 80, // port number doesn't matter because host name is invalid
4242
lookup: common.mustCall(errorLookupMock())
43-
});
43+
}, common.mustNotCall());
4444

4545
client.once('error', common.mustCall((err) => {
4646
assert(err);
Collapse file

‎test/parallel/test-tls-connect.js‎ ‎test/sequential/test-tls-connect.js‎test/parallel/test-tls-connect.js renamed to test/sequential/test-tls-connect.js

Copy file name to clipboard
File renamed without changes.
Collapse file

‎test/parallel/test-tls-lookup.js‎ ‎test/sequential/test-tls-lookup.js‎test/parallel/test-tls-lookup.js renamed to test/sequential/test-tls-lookup.js

Copy file name to clipboard
File renamed without changes.

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.