@@ -100,28 +100,21 @@ request must pass code review and CI before landing into the codebase. |
100 | 100 | ### Code Reviews |
101 | 101 |
|
102 | 102 | At least two Collaborators must approve a pull request before the pull request |
103 | | -lands. (One Collaborator approval is enough if the pull request has been open |
104 | | -for more than 7 days.) Approving a pull request indicates that the Collaborator |
105 | | -accepts responsibility for the change. Approval must be from Collaborators who |
106 | | -are not authors of the change. |
| 103 | +lands. One Collaborator approval is enough if the pull request has been open |
| 104 | +for more than seven days. |
| 105 | + |
| 106 | +Approving a pull request indicates that the Collaborator accepts responsibility |
| 107 | +for the change. |
| 108 | + |
| 109 | +Approval must be from Collaborators who are not authors of the change. |
107 | 110 |
|
108 | 111 | In some cases, it may be necessary to summon a GitHub team to a pull request for |
109 | 112 | review by @-mention. |
110 | 113 | See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). |
111 | 114 |
|
112 | | -If you are unsure about the modification and are not prepared to take |
113 | | -full responsibility for the change, defer to another Collaborator. |
114 | | - |
115 | 115 | If you are the first Collaborator to approve a pull request that has no CI yet, |
116 | | -please start one (see [testing and CI](#testing-and-ci) for further information |
117 | | -on how to do that) and post the link to the CI in the PR. Please also start a |
118 | | -new CI in case the PR creator pushed new code since the last CI run (due to |
119 | | -e.g., an addressed review comment or a rebase). |
120 | | - |
121 | | -In case there are already enough approvals (`LGTM`), a CI run, and the PR is |
122 | | -open longer than the minimum waiting time without any open comments, please do |
123 | | -not (only) add another approval. Instead go ahead and land the PR after checking |
124 | | -the CI outcome. |
| 116 | +please [start one](#testing-and-ci). Post the link to the CI in the PR. Please |
| 117 | +also start a new CI if the PR creator pushed new code since the last CI run. |
125 | 118 |
|
126 | 119 | ### Consensus Seeking |
127 | 120 |
|
|