GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: V8: cherry-pick 705e374124ae · nodejs/node@58c7034

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

common.gypi
deps/v8
- src
  - builtins
  - codegen
  - flags
    - flag-definitions.h
  - init
    - bootstrapper.cc
  - objects
    - objects-inl.h
- test
  - inspector/debugger
    - object-preview-internal-properties.js
  - mjsunit
    - es6
      - collections.js
    - harmony
      - regress
        regress-crbug-1372500.js
      - symbol-as-weakmap-key.js
      - weakrefs
        basics.js
        symbol-as-weakref-target-gc.js
        symbol-as-weakref-target.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎common.gypi‎`

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`
`37`	`37`	`# Reset this number to 0 on major V8 upgrades.`
`38`	`38`	`# Increment by one for each non-official patch applied to deps/v8.`
`39`		`- 'v8_embedder_string': '-node.34',`
	`39`	`+ 'v8_embedder_string': '-node.35',`
`40`	`40`
`41`	`41`	`##### V8 defaults for Node.js #####`
`42`	`42`

Collapse file

`‎deps/v8/src/builtins/builtins-collections-gen.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/builtins-collections-gen.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -399,6 +399,7 @@ TNode<IntPtrT> BaseCollectionsAssembler::EstimatedInitialSize(`
`399`	`399`	`[=] { return IntPtrConstant(0); });`
`400`	`400`	`}`
`401`	`401`
	`402`	`+// https://tc39.es/ecma262/#sec-canbeheldweakly`
`402`	`403`	`void BaseCollectionsAssembler::GotoIfCannotBeHeldWeakly(`
`403`	`404`	`const TNode<Object> obj, Label* if_cannot_be_held_weakly) {`
`404`	`405`	`Label check_symbol_key(this);`
`@@ -411,7 +412,6 @@ void BaseCollectionsAssembler::GotoIfCannotBeHeldWeakly(`
`411`	`412`	`GotoIf(IsJSSharedStructInstanceType(instance_type), if_cannot_be_held_weakly);`
`412`	`413`	`Goto(&end);`
`413`	`414`	`Bind(&check_symbol_key);`
`414`		`- GotoIfNot(HasHarmonySymbolAsWeakmapKeyFlag(), if_cannot_be_held_weakly);`
`415`	`415`	`GotoIfNot(IsSymbolInstanceType(instance_type), if_cannot_be_held_weakly);`
`416`	`416`	`TNode<Uint32T> flags = LoadSymbolFlags(CAST(obj));`
`417`	`417`	`GotoIf(Word32And(flags, Symbol::IsInPublicSymbolTableBit::kMask),`

Collapse file

`‎deps/v8/src/builtins/builtins-weak-refs.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/builtins-weak-refs.cc

+3-7Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,23 +9,19 @@`
`9`	`9`	`namespace v8 {`
`10`	`10`	`namespace internal {`
`11`	`11`
`12`		`-// https://tc39.es/proposal-symbols-as-weakmap-keys/#sec-finalization-registry.prototype.unregister`
	`12`	`+// https://tc39.es/ecma262/#sec-finalization-registry.prototype.unregister`
`13`	`13`	`BUILTIN(FinalizationRegistryUnregister) {`
`14`	`14`	`HandleScope scope(isolate);`
`15`	`15`	`const char* method_name = "FinalizationRegistry.prototype.unregister";`
`16`	`16`
`17`	`17`	`// 1. Let finalizationGroup be the this value.`
`18`	`18`	`//`
`19`		`- // 2. If Type(finalizationGroup) is not Object, throw a TypeError`
`20`		`- // exception.`
`21`		`- //`
`22`		`- // 3. If finalizationGroup does not have a [[Cells]] internal slot,`
`23`		`- // throw a TypeError exception.`
	`19`	`+ // 2. Perform ? RequireInternalSlot(finalizationRegistry, [[Cells]]).`
`24`	`20`	`CHECK_RECEIVER(JSFinalizationRegistry, finalization_registry, method_name);`
`25`	`21`
`26`	`22`	`Handle<Object> unregister_token = args.atOrUndefined(isolate, 1);`
`27`	`23`
`28`		`- // 4. If CanBeHeldWeakly(unregisterToken) is false, throw a TypeError`
	`24`	`+ // 3. If CanBeHeldWeakly(unregisterToken) is false, throw a TypeError`
`29`	`25`	`// exception.`
`30`	`26`	`if (!unregister_token->CanBeHeldWeakly()) {`
`31`	`27`	`THROW_NEW_ERROR_RETURN_FAILURE(`

Collapse file

`‎deps/v8/src/builtins/finalization-registry.tq‎`

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/finalization-registry.tq

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ FinalizationRegistryConstructor(`
`129`	`129`	`return finalizationRegistry;`
`130`	`130`	`}`
`131`	`131`
`132`		`-// https://tc39.es/proposal-symbols-as-weakmap-keys/#sec-finalization-registry.prototype.register`
	`132`	`+// https://tc39.es/ecma262/#sec-finalization-registry.prototype.register`
`133`	`133`	`transitioning javascript builtin`
`134`	`134`	`FinalizationRegistryRegister(`
`135`	`135`	`js-implicit context: NativeContext, receiver: JSAny)(...arguments): JSAny {`

Collapse file

`‎deps/v8/src/builtins/weak-ref.tq‎`

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/weak-ref.tq

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ extern runtime JSWeakRefAddToKeptObjects(implicit context: Context)(`
`13`	`13`
`14`	`14`	`namespace weakref {`
`15`	`15`
`16`		`-// https://tc39.es/proposal-symbols-as-weakmap-keys/#sec-weak-ref-target`
	`16`	`+// https://tc39.es/ecma262/#sec-weak-ref-target`
`17`	`17`	`transitioning javascript builtin`
`18`	`18`	`WeakRefConstructor(`
`19`	`19`	`js-implicit context: NativeContext, receiver: JSAny, newTarget: JSAny,`

Collapse file

`‎deps/v8/src/codegen/code-stub-assembler.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/code-stub-assembler.h

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2679,12 +2679,6 @@ class V8_EXPORT_PRIVATE CodeStubAssembler`
`2679`	`2679`	`ExternalReference::address_of_shared_string_table_flag());`
`2680`	`2680`	`}`
`2681`	`2681`
`2682`		`- TNode<BoolT> HasHarmonySymbolAsWeakmapKeyFlag() {`
`2683`		`- return LoadRuntimeFlag(`
`2684`		`- ExternalReference::`
`2685`		`- address_of_FLAG_harmony_symbol_as_weakmap_key());`
`2686`		`- }`
`2687`		`-`
`2688`	`2682`	`// True iff \|object\| is a Smi or a HeapNumber or a BigInt.`
`2689`	`2683`	`TNode<BoolT> IsNumeric(TNode<Object> object);`
`2690`	`2684`

Collapse file

`‎deps/v8/src/codegen/external-reference.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/external-reference.cc

-5Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -550,11 +550,6 @@ ExternalReference::address_of_mock_arraybuffer_allocator_flag() {`
`550`	`550`	`return ExternalReference(&FLAG_mock_arraybuffer_allocator);`
`551`	`551`	`}`
`552`	`552`
`553`		`-ExternalReference`
`554`		`-ExternalReference::address_of_FLAG_harmony_symbol_as_weakmap_key() {`
`555`		`- return ExternalReference(&FLAG_harmony_symbol_as_weakmap_key);`
`556`		`-}`
`557`		`-`
`558`	`553`	`ExternalReference ExternalReference::address_of_builtin_subclassing_flag() {`
`559`	`554`	`return ExternalReference(&FLAG_builtin_subclassing);`
`560`	`555`	`}`

Collapse file

`‎deps/v8/src/codegen/external-reference.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/external-reference.h

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,6 @@ class StatsCounter;`
`92`	`92`
`93`	`93`	`#define EXTERNAL_REFERENCE_LIST(V) \`
`94`	`94`	`V(abort_with_reason, "abort_with_reason") \`
`95`		`- V(address_of_FLAG_harmony_symbol_as_weakmap_key, \`
`96`		`- "FLAG_harmony_symbol_as_weakmap_key") \`
`97`	`95`	`V(address_of_builtin_subclassing_flag, "FLAG_builtin_subclassing") \`
`98`	`96`	`V(address_of_double_abs_constant, "double_absolute_constant") \`
`99`	`97`	`V(address_of_double_neg_constant, "double_negate_constant") \`

Collapse file

`‎deps/v8/src/flags/flag-definitions.h‎`

Copy file name to clipboardExpand all lines: deps/v8/src/flags/flag-definitions.h

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -319,8 +319,7 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")`
`319`	`319`
`320`	`320`	`// Features that are complete (but still behind the --harmony flag).`
`321`	`321`	`#define HARMONY_STAGED_BASE(V) \`
`322`		`- V(harmony_array_grouping, "harmony array grouping") \`
`323`		`- V(harmony_symbol_as_weakmap_key, "harmony symbols as weakmap keys")`
	`322`	`+ V(harmony_array_grouping, "harmony array grouping")`
`324`	`323`
`325`	`324`	`#ifdef V8_INTL_SUPPORT`
`326`	`325`	`#define HARMONY_STAGED(V) \`

Collapse file

`‎deps/v8/src/init/bootstrapper.cc‎`

Copy file name to clipboardExpand all lines: deps/v8/src/init/bootstrapper.cc

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4484,7 +4484,6 @@ void Genesis::InitializeConsole(Handle<JSObject> extras_binding) {`
`4484`	`4484`	`EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_import_assertions)`
`4485`	`4485`	`EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_private_brand_checks)`
`4486`	`4486`	`EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_class_static_blocks)`
`4487`		`-EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_symbol_as_weakmap_key)`
`4488`	`4487`	`EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_error_cause)`
`4489`	`4488`
`4490`	`4489`	`#ifdef V8_INTL_SUPPORT`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.