GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: avoid flaky debugger restart waits · nodejs/node@604456c

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test/parallel
    • test-debugger-restart-message.js
    • test-debugger-run-after-quit-restart.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-debugger-restart-message.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debugger-restart-message.js
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ const startCLI = require('../common/debugger');
2525
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);
2626

2727
for (let i = 0; i < RESTARTS; i++) {
28-
await cli.stepCommand('restart');
28+
// For `restart`, sync on attach/prompt instead of BREAK_MESSAGE to avoid flaky races.
29+
// https://github.com/nodejs/node/issues/61762
30+
await cli.command('restart');
31+
await cli.waitFor(/Debugger attached\./);
32+
await cli.waitForPrompt();
2933
assert.strictEqual(cli.output.match(listeningRegExp).length, 1);
3034
}
3135
} finally {
Collapse file

‎test/parallel/test-debugger-run-after-quit-restart.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debugger-run-after-quit-restart.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const path = require('path');
5757
{ filename: script, line: 2 },
5858
);
5959
})
60-
.then(() => cli.stepCommand('restart'))
60+
.then(() => cli.command('restart'))
6161
.then(() => cli.waitForInitialBreak())
6262
.then(() => {
6363
assert.deepStrictEqual(

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.