GeezerVison is showing github.com — sqlite: remove unused column name helper · nodejs/node@60cb384
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/node_sqlite.cc -14Lines changed: 0 additions & 14 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -3158,20 +3158,6 @@ MaybeLocal<Value> StatementExecutionHelper::ColumnToValue(Environment* env, |
3158 | 3158 | return js_val; |
3159 | 3159 | } |
3160 | 3160 |
|
3161 | | -MaybeLocal<Name> StatementExecutionHelper::ColumnNameToName(Environment* env, |
3162 | | - sqlite3_stmt* stmt, |
3163 | | - const int column) { |
3164 | | - const char* col_name = sqlite3_column_name(stmt, column); |
3165 | | - if (col_name == nullptr) { |
3166 | | - THROW_ERR_INVALID_STATE(env, "Cannot get name of column %d", column); |
3167 | | - return MaybeLocal<Name>(); |
3168 | | - } |
3169 | | - |
3170 | | - return String::NewFromUtf8( |
3171 | | - env->isolate(), col_name, NewStringType::kInternalized) |
3172 | | - .As<Name>(); |
3173 | | -} |
3174 | | - |
3175 | 3161 | void StatementSync::MemoryInfo(MemoryTracker* tracker) const {} |
3176 | 3162 |
|
3177 | 3163 | Maybe<void> ExtractRowValues(Environment* env, |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_sqlite.h -3Lines changed: 0 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -187,9 +187,6 @@ class StatementExecutionHelper { |
187 | 187 | sqlite3_stmt* stmt, |
188 | 188 | const int column, |
189 | 189 | bool use_big_ints); |
190 | | - static v8::MaybeLocal<v8::Name> ColumnNameToName(Environment* env, |
191 | | - sqlite3_stmt* stmt, |
192 | | - const int column); |
193 | 190 | static v8::MaybeLocal<v8::Value> Get(Environment* env, |
194 | 191 | StatementSync* statement); |
195 | 192 | }; |
|