GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: revise handling-own-pull-requests text · nodejs/node@6788d85

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

COLLABORATOR_GUIDE.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎COLLABORATOR_GUIDE.md‎`

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md

+11-13Lines changed: 11 additions & 13 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -76,22 +76,20 @@ A pull request is _author ready_ when:`
`76`	`76`	`pull request is older than 7 days.`
`77`	`77`	`* There are no outstanding review comments.`
`78`	`78`
`79`		-Please always add the `author ready` label to the PR in that case. Please always
`80`		`-remove it again as soon as the conditions are not met anymore.`
	`79`	+Please always add the `author ready` label to the pull request in that case.
	`80`	`+Please always remove it again as soon as the conditions are not met anymore.`
`81`	`81`
`82`	`82`	`### Handling own pull requests`
`83`	`83`
`84`		`-When you open a pull request, it is recommended to start a CI right away (see`
`85`		`-[testing and CI](#testing-and-ci) for instructions) and to post the link to it`
`86`		`-in a comment in the pull request. Starting a new CI after each update is also`
`87`		`-recommended (for example, after an additional code change or after rebasing).`
`88`		`-`
`89`		`-As soon as the PR is ready to land, please do so. Landing your own pull requests`
`90`		`-allows other Collaborators to focus on other pull requests. If your pull request`
`91`		`-is still awaiting the [minimum time to land](#waiting-for-approvals), add the`
`92`		-`author ready` label so other Collaborators know it can land as soon as the time
`93`		`-ends. If instead you wish to land the PR yourself, indicate this intent by using`
`94`		`-the "assign yourself" button, to self-assign the PR.`
	`84`	`+When you open a pull request, [start a CI](#testing-and-ci) right away and post`
	`85`	`+the link to it in a comment in the pull request. Later, after new code changes`
	`86`	`+or rebasing, start a new CI.`
	`87`	`+`
	`88`	`+As soon as the pull request is ready to land, please do so. This allows other`
	`89`	`+Collaborators to focus on other pull requests. If your pull request is not ready`
	`90`	`+to land but is [author ready](#author-ready-pull-requests), add the`
	`91`	+`author ready` label. If you wish to land the pull request yourself, use the
	`92`	`+"assign yourself" link to self-assign it.`
`95`	`93`
`96`	`94`	`## Accepting Modifications`
`97`	`95`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.