GeezerVison is showing github.com — net: fix setting of value in 'setDefaultAutoSelectFamilyAttemptTimeout' · nodejs/node@67fe7d8
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: doc/api/net.md +1-1Lines changed: 1 addition & 1 deletion - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -1670,7 +1670,7 @@ added: v18.18.0 |
1670 | 1670 | Sets the default value of the `autoSelectFamilyAttemptTimeout` option of [`socket.connect(options)`][]. |
1671 | 1671 |
|
1672 | 1672 | * `value` {number} The new default value, which must be a positive number. If the number is less than `10`, |
1673 | | - the value `10` is used insted The initial default value is `250`. |
| 1673 | + the value `10` is used instead. The initial default value is `250`. |
1674 | 1674 |
|
1675 | 1675 | ## `net.isIP(input)` |
1676 | 1676 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: lib/net.js +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -265,7 +265,7 @@ function getDefaultAutoSelectFamilyAttemptTimeout() { |
265 | 265 | function setDefaultAutoSelectFamilyAttemptTimeout(value) { |
266 | 266 | validateInt32(value, 'value', 1); |
267 | 267 |
|
268 | | - if (value < 1) { |
| 268 | + if (value < 10) { |
269 | 269 | value = 10; |
270 | 270 | } |
271 | 271 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js +7Lines changed: 7 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -18,3 +18,10 @@ for (const autoSelectFamilyAttemptTimeout of [-10, 0]) { |
18 | 18 | net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout); |
19 | 19 | }, { code: 'ERR_OUT_OF_RANGE' }); |
20 | 20 | } |
| 21 | + |
| 22 | +// Check the default value of autoSelectFamilyAttemptTimeout is 10 |
| 23 | +// if passed number is less than 10 |
| 24 | +for (const autoSelectFamilyAttemptTimeout of [1, 9]) { |
| 25 | + net.setDefaultAutoSelectFamilyAttemptTimeout(autoSelectFamilyAttemptTimeout); |
| 26 | + assert.strictEqual(net.getDefaultAutoSelectFamilyAttemptTimeout(), 10); |
| 27 | +} |