GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: enable no-useless-constructor lint rule · nodejs/node@694ea00

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

.eslintrc.js
doc/api
- stream.md
lib
- perf_hooks.js
- v8.js
test/parallel
- test-stream-writable-null.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎.eslintrc.js‎`

Copy file name to clipboardExpand all lines: .eslintrc.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,7 @@ module.exports = {`
`223`	`223`	`}],`
`224`	`224`	`'no-useless-call': 'error',`
`225`	`225`	`'no-useless-concat': 'error',`
	`226`	`+ 'no-useless-constructor': 'error',`
`226`	`227`	`'no-useless-escape': 'error',`
`227`	`228`	`'no-useless-return': 'error',`
`228`	`229`	`'no-void': 'error',`

Collapse file

`‎doc/api/stream.md‎`

Copy file name to clipboardExpand all lines: doc/api/stream.md

+5-5Lines changed: 5 additions & 5 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1441,6 +1441,7 @@ of the four basic stream classes (`stream.Writable`, `stream.Readable`,
`1441`	`1441`	`stream.Duplex`, or `stream.Transform`), making sure they call the appropriate
`1442`	`1442`	`parent class constructor:`
`1443`	`1443`
	`1444`	`+<!-- eslint-disable no-useless-constructor -->`
`1444`	`1445`	```js
`1445`	`1446`	`const { Writable } = require('stream');`
`1446`	`1447`
`@@ -1531,6 +1532,7 @@ changes:`
`1531`	`1532`	* `final` {Function} Implementation for the
`1532`	`1533`	[`stream._final()`][stream-_final] method.
`1533`	`1534`
	`1535`	`+<!-- eslint-disable no-useless-constructor -->`
`1534`	`1536`	```js
`1535`	`1537`	`const { Writable } = require('stream');`
`1536`	`1538`
@@ -1702,11 +1704,6 @@ required elements of a custom [`Writable`][] stream instance:
`1702`	`1704`	`const { Writable } = require('stream');`
`1703`	`1705`
`1704`	`1706`	`class MyWritable extends Writable {`
`1705`		`- constructor(options) {`
`1706`		`- super(options);`
`1707`		`- // ...`
`1708`		`- }`
`1709`		`-`
`1710`	`1707`	`_write(chunk, encoding, callback) {`
`1711`	`1708`	`if (chunk.toString().indexOf('a') >= 0) {`
`1712`	`1709`	`callback(new Error('chunk is invalid'));`
@@ -1780,6 +1777,7 @@ constructor and implement the `readable._read()` method.
`1780`	`1777`	* `destroy` {Function} Implementation for the
`1781`	`1778`	[`stream._destroy()`][readable-_destroy] method.
`1782`	`1779`
	`1780`	`+<!-- eslint-disable no-useless-constructor -->`
`1783`	`1781`	```js
`1784`	`1782`	`const { Readable } = require('stream');`
`1785`	`1783`
`@@ -2038,6 +2036,7 @@ changes:`
`2038`	`2036`	* `writableHighWaterMark` {number} Sets `highWaterMark` for the writable side
`2039`	`2037`	of the stream. Has no effect if `highWaterMark` is provided.
`2040`	`2038`
	`2039`	`+<!-- eslint-disable no-useless-constructor -->`
`2041`	`2040`	```js
`2042`	`2041`	`const { Duplex } = require('stream');`
`2043`	`2042`
@@ -2192,6 +2191,7 @@ output on the `Readable` side is not consumed.
`2192`	`2191`	* `flush` {Function} Implementation for the [`stream._flush()`][stream-_flush]
`2193`	`2192`	`method.`
`2194`	`2193`
	`2194`	`+<!-- eslint-disable no-useless-constructor -->`
`2195`	`2195`	```js
`2196`	`2196`	`const { Transform } = require('stream');`
`2197`	`2197`

Collapse file

`‎lib/perf_hooks.js‎`

Copy file name to clipboardExpand all lines: lib/perf_hooks.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,6 @@ function getMilestoneTimestamp(milestoneIdx) {`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`class PerformanceNodeTiming {`
`145`		`- constructor() {}`
`146`		`-`
`147`	`145`	`get name() {`
`148`	`146`	`return 'node';`
`149`	`147`	`}`

Collapse file

`‎lib/v8.js‎`

Copy file name to clipboardExpand all lines: lib/v8.js

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,10 +173,6 @@ class DefaultSerializer extends Serializer {`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`class DefaultDeserializer extends Deserializer {`
`176`		`- constructor(buffer) {`
`177`		`- super(buffer);`
`178`		`- }`
`179`		`-`
`180`	`176`	`_readHostObject() {`
`181`	`177`	`const typeIndex = this.readUint32();`
`182`	`178`	`const ctor = arrayBufferViewTypes[typeIndex];`

Collapse file

`‎test/parallel/test-stream-writable-null.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-stream-writable-null.js

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,10 +5,6 @@ const assert = require('assert');`
`5`	`5`	`const stream = require('stream');`
`6`	`6`
`7`	`7`	`class MyWritable extends stream.Writable {`
`8`		`- constructor(opt) {`
`9`		`- super(opt);`
`10`		`- }`
`11`		`-`
`12`	`8`	`_write(chunk, encoding, callback) {`
`13`	`9`	`assert.notStrictEqual(chunk, null);`
`14`	`10`	`callback();`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.