GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: always define V8_EXPORT_PRIVATE as no-op · nodejs/node@69ad89f

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • common.gypi
  • deps/v8/src/base
    • macros.h
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.0',
39+
'v8_embedder_string': '-node.1',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/src/base/macros.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/base/macros.h
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -423,9 +423,9 @@ bool is_inbounds(float_t v) {
423423
// Setup for Windows shared library export.
424424
#define V8_EXPORT_ENUM
425425
#ifdef BUILDING_V8_SHARED_PRIVATE
426-
#define V8_EXPORT_PRIVATE __declspec(dllexport)
426+
#define V8_EXPORT_PRIVATE
427427
#elif USING_V8_SHARED_PRIVATE
428-
#define V8_EXPORT_PRIVATE __declspec(dllimport)
428+
#define V8_EXPORT_PRIVATE
429429
#else
430430
#define V8_EXPORT_PRIVATE
431431
#endif // BUILDING_V8_SHARED
@@ -435,8 +435,8 @@ bool is_inbounds(float_t v) {
435435
// Setup for Linux shared library export.
436436
#if V8_HAS_ATTRIBUTE_VISIBILITY
437437
#ifdef BUILDING_V8_SHARED_PRIVATE
438-
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
439-
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
438+
#define V8_EXPORT_PRIVATE
439+
#define V8_EXPORT_ENUM
440440
#else
441441
#define V8_EXPORT_PRIVATE
442442
#define V8_EXPORT_ENUM

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.