GeezerVison is showing github.com — deps: always define V8_EXPORT_PRIVATE as no-op · nodejs/node@69ad89f
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: common.gypi +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
36 | 36 |
|
37 | 37 | # Reset this number to 0 on major V8 upgrades. |
38 | 38 | # Increment by one for each non-official patch applied to deps/v8. |
39 | | - 'v8_embedder_string': '-node.0', |
| 39 | + 'v8_embedder_string': '-node.1', |
40 | 40 |
|
41 | 41 | ##### V8 defaults for Node.js ##### |
42 | 42 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: deps/v8/src/base/macros.h +4-4Lines changed: 4 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -423,9 +423,9 @@ bool is_inbounds(float_t v) { |
423 | 423 | // Setup for Windows shared library export. |
424 | 424 | #define V8_EXPORT_ENUM |
425 | 425 | #ifdef BUILDING_V8_SHARED_PRIVATE |
426 | | -#define V8_EXPORT_PRIVATE __declspec(dllexport) |
| 426 | +#define V8_EXPORT_PRIVATE |
427 | 427 | #elif USING_V8_SHARED_PRIVATE |
428 | | -#define V8_EXPORT_PRIVATE __declspec(dllimport) |
| 428 | +#define V8_EXPORT_PRIVATE |
429 | 429 | #else |
430 | 430 | #define V8_EXPORT_PRIVATE |
431 | 431 | #endif // BUILDING_V8_SHARED |
@@ -435,8 +435,8 @@ bool is_inbounds(float_t v) { |
435 | 435 | // Setup for Linux shared library export. |
436 | 436 | #if V8_HAS_ATTRIBUTE_VISIBILITY |
437 | 437 | #ifdef BUILDING_V8_SHARED_PRIVATE |
438 | | -#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) |
439 | | -#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE |
| 438 | +#define V8_EXPORT_PRIVATE |
| 439 | +#define V8_EXPORT_ENUM |
440 | 440 | #else |
441 | 441 | #define V8_EXPORT_PRIVATE |
442 | 442 | #define V8_EXPORT_ENUM |
|