GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove err timer from test-http-set-timeout · nodejs/node@6d742b3

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test/parallel
    • test-http-set-timeout.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-http-set-timeout.js‎

Copy file name to clipboard
+13-19Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,26 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var http = require('http');
5-
var net = require('net');
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const http = require('http');
5+
const net = require('net');
66

77
var server = http.createServer(function(req, res) {
8-
console.log('got request. setting 1 second timeout');
9-
var s = req.connection.setTimeout(500);
10-
assert.ok(s instanceof net.Socket);
11-
req.connection.on('timeout', function() {
8+
console.log('got request. setting 500ms timeout');
9+
var socket = req.connection.setTimeout(500);
10+
assert.ok(socket instanceof net.Socket);
11+
req.connection.on('timeout', common.mustCall(function() {
1212
req.connection.destroy();
1313
console.error('TIMEOUT');
1414
server.close();
15-
});
15+
}));
1616
});
1717

1818
server.listen(0, function() {
1919
console.log(`Server running at http://127.0.0.1:${this.address().port}/`);
2020

21-
var errorTimer = setTimeout(function() {
22-
throw new Error('Timeout was not successful');
23-
}, common.platformTimeout(2000));
24-
25-
var x = http.get({port: this.address().port, path: '/'});
26-
x.on('error', function() {
27-
clearTimeout(errorTimer);
21+
var request = http.get({port: this.address().port, path: '/'});
22+
request.on('error', common.mustCall(function() {
2823
console.log('HTTP REQUEST COMPLETE (this is good)');
29-
});
30-
x.end();
31-
24+
}));
25+
request.end();
3226
});

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.