GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: relax min assertion in test-performance-eventloopdelay · nodejs/node@6d7cd50

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test/sequential
    • test-performance-eventloopdelay.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/sequential/test-performance-eventloopdelay.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-performance-eventloopdelay.js
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,11 @@ const { sleep } = require('internal/util');
7171
// The values are non-deterministic, so we just check that a value is
7272
// present, as opposed to a specific value.
7373
assert(histogram.count > 0, `Expected samples to be recorded, got count=${histogram.count}`);
74-
assert(histogram.min > 0);
74+
// Min can legitimately be 0: the underlying HDR histogram has a
75+
// lowest discernible value of 1us, so samples whose delta falls in
76+
// the [0, 1us) bucket are reported as 0. A negative value would
77+
// indicate a bug.
78+
assert(histogram.min >= 0);
7579
assert(histogram.max > 0);
7680
assert(histogram.stddev > 0);
7781
assert(histogram.mean > 0);

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.